GNOME Bugzilla – Bug 754607
screenshot windows are too small on a hidpi monitor
Last modified: 2016-01-08 14:25:10 UTC
Sorry for possibly assigning to the wrong component. I couldn't find one for gnome-shell-extensions. The gnome-shell-extension-screenshot-window-sizer extension works, but it gives the wrong sizes on my hidpi monitor. It would need to double the numbers to be correct.
Created attachment 318451 [details] [review] screenshot-window-sizer: hidpi support
(In reply to Will Thompson from comment #1) > Created attachment 318451 [details] [review] [review] > screenshot-window-sizer: hidpi support I've not tested this on a low-dpi screen, mind you :-)
Review of attachment 318451 [details] [review]: (In reply to Will Thompson from comment #2) > I've not tested this on a low-dpi screen, mind you :-) I did, but *only* on a low-dpi screen :-) The sizing code looks right to me, but I'm wondering whether we should report the unscaled values in the info overlay?
Created attachment 318495 [details] [review] screenshot-window-sizer: hidpi support The new logical dimensions are reported in the overlay, rather than the pixel dimensions. That is: if scaleFactor is 2, a window might be resized to 2400×1350 device pixels, which will be reported as 1200×675 in the overlay. This is consistent with (for example) the DevTools in Chrome, which reports the logical size of the viewport when you resize the window, rather than the physical pixel size. Tested with a freely-resizable window and with a constrained-geometry window (GNOME Terminal), on a hidpi display.
Review of attachment 318495 [details] [review]: LGTM, thanks!
Thanks! Attachment 318495 [details] pushed as 5b1f770 - screenshot-window-sizer: hidpi support