After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 754582 - Glib cannot compile
Glib cannot compile
Status: RESOLVED FIXED
Product: glib
Classification: Platform
Component: gio
2.45.x
Other Mac OS
: Normal critical
: ---
Assigned To: gtkdev
gtkdev
Depends on:
Blocks:
 
 
Reported: 2015-09-04 17:53 UTC by Partha
Modified: 2015-09-07 17:11 UTC
See Also:
GNOME target: ---
GNOME version: ---


Description Partha 2015-09-04 17:53:03 UTC 
gliststore.c:337:3: error: void function 'g_list_store_sort' should not return a value [-Wreturn-type]
  g_return_val_if_fail (compare_func != NULL, 0);
  ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
../glib/gmessages.h:388:3: note: expanded from macro 'g_return_val_if_fail'
         return (val);                                                  \
         ^      ~~~~~
Comment 1 Partha 2015-09-04 18:37:00 UTC 
Wow! That was a fast bug fix!

However, after applying the fix to gsequence.c I am still getting the error in gio/gliststore.c as mentioned above?

Should the above be g_return_val_if_fail( compare_func != NULL ); ?

Thanks,
Partha
Comment 2 Partha 2015-09-05 03:44:29 UTC 
I meant to say g_return_if_fail( compare_func != NULL );
Comment 3 Matthias Clasen 2015-09-07 17:11:42 UTC 
See 

commit 4a09d0cf7a65cd08d4156eafd80e943712216d49
Author: Ting-Wei Lan <lantw@src.gnome.org>
Date:   Wed Sep 2 01:19:40 2015 +0800

    Fix return value error in g_list_store_sort