After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 754558 - smpte: Use video info data instead of macro
smpte: Use video info data instead of macro
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-good
unspecified
Other Linux
: Normal minor
: 1.7.1
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2015-09-04 08:41 UTC by RaviKiran
Modified: 2015-10-02 14:38 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
use videoinfo data (3.35 KB, patch)
2015-09-04 08:43 UTC, RaviKiran 		committed Details | Review

Description RaviKiran 2015-09-04 08:41:29 UTC 
To get the size, offset and stride, hard coded macros are used. 
Instead, VideoInfo data can used to get those info.
Comment 1 RaviKiran 2015-09-04 08:43:26 UTC 
Created attachment 310646 [details] [review]
use videoinfo data

Pls review the patch
Comment 2 Sebastian Dröge (slomo) 2015-09-04 09:31:09 UTC 
Comment on attachment 310646 [details] [review]
use videoinfo data

Or even better, use the GstVideoFrame API :)
Comment 3 Sebastian Dröge (slomo) 2015-10-02 14:38:23 UTC 
commit b71068e42d99fa38efea70e68cf990bdc8a6bdb2
Author: Ravi Kiran K N <ravi.kiran@samsung.com>
Date:   Fri Sep 4 14:24:45 2015 +0530

    smpte: get size, stride info using VideoInfo
    
    Use VideoInfo data to get size stride and
    offset, instead of hard coded macros.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=754558