After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 754506 - Cheese integration fails on 3.17.90
Cheese integration fails on 3.17.90
Status: RESOLVED FIXED
Product: cheese
Classification: Applications
Component: general
3.17.x
Other Linux
: Normal normal
: ---
Assigned To: Cheese Maintainer(s)
Cheese Maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2015-09-03 09:55 UTC by mpiazza
Modified: 2015-09-04 08:28 UTC
See Also:
GNOME target: 3.18
GNOME version: ---

Attachments
Stacktrace of gcc crash (1.71 KB, text/plain)
2015-09-03 18:45 UTC, mpiazza 		  Details
Tentative patch (1.28 KB, patch)
2015-09-03 22:25 UTC, mpiazza 		rejected Details | Review

Description mpiazza 2015-09-03 09:55:05 UTC 
After the port of cheese to clutter-gst-3.0 using webcam to take a photos in User accounts does not work anymore.

This is building:
Cheese 3.17.90
Gnome-control-center 3.17.90

The commit in cheese that broke g-c-c is:
https://git.gnome.org/browse/cheese/commit/?id=9df993253d58c2442ab92df613f5754ead5b5e20
Comment 1 Bastien Nocera 2015-09-03 10:02:32 UTC 
Not sure why you file a bug against gnome-control-center then...

You might want to explain what "does not work anymore" means.
Comment 2 mpiazza 2015-09-03 11:23:55 UTC 
Sorry, for not have been clear.

I think gnome 3.18 will be released with
cheese 3.18 and gnome-control-center 3.18
but cheese broke ABI and API in 3.17.90
(https://git.gnome.org/browse/cheese/commit/?id=1b86b95503b84b5c2d582b43ee83753c9c8f9ba7)
and this break pre-exixting gnome-control-center.
Anyway I will give more information in a few days.
Comment 3 Bastien Nocera 2015-09-03 11:25:22 UTC 
Then you'll need to rebuild gnome-control-center. Was there anything else?
Comment 4 mpiazza 2015-09-03 18:44:00 UTC 
Clicking on avatar and then "Take a snapshot.." 
gnome-control-center crash:

(gnome-control-center:2256): GLib-GObject-CRITICAL **: g_object_new_valist: obje
ct class 'CheeseCamera' has no property named 'device-node'
Comment 5 mpiazza 2015-09-03 18:45:06 UTC 
Created attachment 310614 [details]
Stacktrace of gcc crash

See attached stack trace of the crash
Comment 6 Bastien Nocera 2015-09-03 20:59:22 UTC 
$ ./cheese-test-widget 
(lt-cheese-test-widget:26224): GLib-GObject-CRITICAL **: g_object_new_valist: object class 'CheeseCamera' has no property named 'device-node'

A bug in libcheese.
Comment 7 mpiazza 2015-09-03 22:25:57 UTC 
Created attachment 310620 [details] [review]
Tentative patch

Using the patch attached makes gnome-control-center happy again.
Comment 8 David King 2015-09-04 08:28:04 UTC 
Review of attachment 310620 [details] [review]:

This fixes the crash, but I pushed an improved fix as commit b89ed15b156cdef303b8fd7593751160d1dfd4fc and commit 4b28da6cc6809986e44ab9487ba494326e43a779