After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 754495 - videoaggregator: No protection from receiving interlaced and non-interlaced content
videoaggregator: No protection from receiving interlaced and non-interlaced c...
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-bad
git master
Other All
: Normal normal
: 1.9.1
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on: 754291
Blocks:
 
 
Reported: 2015-09-02 22:50 UTC by Thiago Sousa Santos
Modified: 2016-04-18 17:25 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
videoaggregator: lift restriction on interlaced-mode (5.15 KB, patch)
2016-03-28 18:47 UTC, Thiago Sousa Santos
none Details | Review
videoaggregator: properly handle interlace-mode restrictions (11.68 KB, patch)
2016-03-30 15:43 UTC, Thiago Sousa Santos
committed Details | Review

Description Thiago Sousa Santos 2015-09-02 22:50:40 UTC
+++ This bug was initially created as a clone of Bug #754291 +++

See the original bug.

It seems that it is possible to set caps to two sink pads in compositor to interlaced and non-interlaced and it will accept it.

Need to make sure that it only accepts of one type. Unit tests are highly appreciated.
Comment 1 Sebastian Dröge (slomo) 2015-09-03 07:15:49 UTC
Why is this a blocker bug? Should we make sure to fix it before 1.6?
Comment 2 Thiago Sousa Santos 2015-09-03 10:23:55 UTC
Sorry, not a blocker.
Comment 3 Thiago Sousa Santos 2016-03-28 18:47:53 UTC
Created attachment 324890 [details] [review]
videoaggregator: lift restriction on interlaced-mode

The internal converters can handle it
Comment 4 Sebastian Dröge (slomo) 2016-03-29 07:26:06 UTC
Comment on attachment 324890 [details] [review]
videoaggregator: lift restriction on interlaced-mode

No, GstVideoConverter can't deinterlace or interlace content.
Comment 5 Thiago Sousa Santos 2016-03-30 15:43:15 UTC
Created attachment 325029 [details] [review]
videoaggregator: properly handle interlace-mode restrictions

You're right, I got confused with videotestsrc not putting interlace-mode in its caps
(which implicitly means progressive) and using a capsfilter after it that would filter
to 'interleaved'. That seemed to be working nicely but was all a lie.

One downsize for this change is that caps queries from compositor will now return
interlace-mode in its caps which will become yet another required field for video
caps for subset checks to work.
Comment 6 Thiago Sousa Santos 2016-04-18 17:21:23 UTC
commit 641bb44226f6b12dbe8fb5a3b3f76d76ff720aa1
Author: Thiago Santos <thiagoss@osg.samsung.com>
Date:   Mon Mar 28 15:44:27 2016 -0300

    videoaggregator: properly handle interlace-mode restrictions
    
    videoaggregator can't handle interlace-mode changes so it must
    always restrict itself to the first interlacing mode it receives.
    
    Tests included
    
    https://bugzilla.gnome.org/show_bug.cgi?id=754495