After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 754489 - thetvdb: use https rather than insecure http
thetvdb: use https rather than insecure http
Status: RESOLVED FIXED
Product: grilo
Classification: Other
Component: plugins
git master
Other Linux
: Normal normal
: ---
Assigned To: grilo-maint
grilo-maint
Depends on:
Blocks:
 
 
Reported: 2015-09-02 20:35 UTC by Elad Alfassa
Modified: 2015-09-03 07:13 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
[PATCH] thetvdb: Use HTTPS rather than insecure HTTP (986 bytes, patch)
2015-09-02 20:37 UTC, Elad Alfassa 		none Details | Review
[PATCH] thetvdb: Use HTTPS rather than insecure HTTP (986 bytes, patch)
2015-09-02 21:08 UTC, Elad Alfassa 		none Details | Review
[PATCH] thetvdb: Use HTTPS rather than insecure HTTP (3.74 KB, patch)
2015-09-02 21:08 UTC, Elad Alfassa 		none Details | Review
[PATCH] thetvdb: Use HTTPS rather than insecure HTTP (18.19 KB, patch)
2015-09-02 21:26 UTC, Elad Alfassa 		committed Details | Review

Description Elad Alfassa 2015-09-02 20:35:13 UTC 
thetvdb finally added https support, so the grilo plugin for thetvdb should use https when accessing the service, to keep users safe and secure.

The patch is of course a one letter change, and I'll attach it to this bug shortly.
Comment 1 Elad Alfassa 2015-09-02 20:37:07 UTC 
Created attachment 310541 [details] [review]
[PATCH] thetvdb: Use HTTPS rather than insecure HTTP
Comment 2 Victor Toso 2015-09-02 20:58:10 UTC 
Review of attachment 310541 [details] [review]:

Yes! That's look good!
Testing with grl-launch-0.2 shows that it works normally!

Could you please also fix the tests by changing the http to https in tests/thetvdb/data/config.ini?
:)
Comment 3 Elad Alfassa 2015-09-02 21:08:06 UTC 
Created attachment 310542 [details] [review]
[PATCH] thetvdb: Use HTTPS rather than insecure HTTP

Done.
Comment 4 Elad Alfassa 2015-09-02 21:08:27 UTC 
Argh submitted the wrong version of the patch, hold on
Comment 5 Elad Alfassa 2015-09-02 21:08:56 UTC 
Created attachment 310543 [details] [review]
[PATCH] thetvdb: Use HTTPS rather than insecure HTTP

Okay, I'm pretty sure I got the right one now :)
Comment 6 Victor Toso 2015-09-02 21:21:59 UTC 
That fixed the test but now we get this messages from the tests, due the change from http to https

/thetvdb/resolve/episodes_from_episode: ** Message: [Boardwalk Empire] Episode screen changed from
http://thetvdb.com/banners/episodes/84947/4596908.jpg
to
https://thetvdb.com/banners/episodes/84947/4596908.jpg

Do you mind changing it inside the tests as well so we don't get any message?
:)
Comment 7 Elad Alfassa 2015-09-02 21:26:46 UTC 
Created attachment 310545 [details] [review]
[PATCH] thetvdb: Use HTTPS rather than insecure HTTP

Sure. I didn't realize it exists in so many places to be changed!
Comment 8 Bastien Nocera 2015-09-02 21:38:29 UTC 
(In reply to Elad Alfassa from comment #7)
> Created attachment 310545 [details] [review] [review]
> [PATCH] thetvdb: Use HTTPS rather than insecure HTTP
> 
> Sure. I didn't realize it exists in so many places to be changed!

Trying running "make check" ;)
Comment 9 Victor Toso 2015-09-03 07:10:07 UTC 
Review of attachment 310545 [details] [review]:

Looks great! Many thanks!
Comment 10 Victor Toso 2015-09-03 07:13:31 UTC 
Review of attachment 310545 [details] [review]:

git bz push did not change the patch to commited!

https://git.gnome.org/browse/grilo-plugins/commit/?id=f4e44c23c15fd14eacf9bfaa5a40801ed94b941b