Bug 754446 – failed to raise FatalError if package is not meta

After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.

Bug 754446 - failed to raise FatalError if package is not meta


Summary:	failed to raise FatalError if package is not meta


Status:	RESOLVED OBSOLETE

Product:	GStreamer
Classification:	Platform
Component:	cerbero
Version:	git master
Hardware:	Other Mac OS

Importance:	Normal normal
Target Milestone:	git master
Assigned To:	GStreamer Maintainers
QA Contact:	GStreamer Maintainers

URL:
Whiteboard:

Depends on:
Blocks:

Reported:	2015-09-02 10:37 UTC by Justin Kim
Modified:	2017-12-15 14:29 UTC

See Also:
GNOME target:	---
GNOME version:	---

Attachments
remove comma (1.13 KB, patch) 2015-09-02 10:43 UTC, Justin Kim	none	Details \| Review
fix typo and refine message (1.13 KB, patch) 2015-09-03 05:49 UTC, Justin Kim	none	Details \| Review

Description Justin Kim 2015-09-02 10:37:28 UTC

If package is not meta package, FatalError is called in Packager class.
However, due to comma in an error message, it looks like something wrong in cerbero.

eg. 
$ ./cerbero-uninstalled -c config/cross-ios-arm64.cbc package gstreamer-1.0-editing

Traceback (most recent call last):

+ Trace 235411

File "./cerbero-uninstalled", line 9 in <module>
```
main()
```
File "./cerbero/main.py", line 130 in main
```
Main(sys.argv[1:])
```
File "./cerbero/main.py", line 55 in __init__
```
self.run_command()
```
File "./cerbero/main.py", line 105 in run_command
```
res = commands.run(command, self.config, self.args)
```
File "./cerbero/commands/__init__.py", line 78 in run
```
return _commands[command].run(config, args)
```
File "./cerbero/commands/package.py", line 90 in run
```
pkg = Packager(config, p, self.store)
```
File "./cerbero/packages/packager.py", line 53 in __new__
```
return _packagers[d][v](config, package, store)
```
File "./cerbero/packages/osx/packager.py", line 612 in __new__
```
"for MetaPackage")
```

TypeError: __init__() takes at most 2 arguments (3 given)



Expected result maybe like this;

Traceback (most recent call last):
  File "./cerbero/main.py", line 105, in run_command
    res = commands.run(command, self.config, self.args)
  File "./cerbero/commands/__init__.py", line 78, in run
    return _commands[command].run(config, args)
  File "./cerbero/commands/package.py", line 90, in run
    pkg = Packager(config, p, self.store)
  File "./cerbero/packages/packager.py", line 53, in __new__
    return _packagers[d][v](config, package, store)
  File "./cerbero/packages/osx/packager.py", line 611, in __new__
    raise FatalError ("iOS platform only support packages "
FatalError: Fatal Error: iOS platform only support packages for MetaPackage
***** Error running 'package' command:
Fatal Error: iOS platform only support packages for MetaPackage
usage: cerbero-uninstalled [-h] [-c CONFIG]
                           {add-recipe,rdeps,tag,genxcconfig,genlibfiles,check,list-packages,show-config,add-package,build,genvsprops,shell,run,cleanone,packageinfo,buildone,wipe,debug-packages,package,bootstrap,list,checkpackage,deps,gensdkshell,fetch-package,fetch}
                           ...

Comment 1 Justin Kim 2015-09-02 10:43:33 UTC

Created attachment 310479 [details] [review]
remove comma

Comment 2 Justin Kim 2015-09-03 05:49:56 UTC

Created attachment 310562 [details] [review]
fix typo and refine message

Comment 3 Justin Kim 2015-09-09 14:36:20 UTC

ping? is this not acceptable?

Comment 4 Justin Kim 2017-12-15 14:29:24 UTC

Too old bug.