GNOME Bugzilla – Bug 754435
flvmux: use time segment and copy timestamps when streamable
Last modified: 2015-10-11 10:39:33 UTC
Created attachment 310473 [details] [review] patch with test Ref. discussion with slomo, __tim and stormer.
Review of attachment 310473 [details] [review]: ::: gst/flv/gstflvmux.c @@ +1126,3 @@ + } else { + GST_BUFFER_OFFSET (tag) = GST_BUFFER_OFFSET (buffer); + GST_BUFFER_OFFSET_END (tag) = GST_BUFFER_OFFSET_END (buffer); Copying the offsets seem not very useful either here. They are going to be values specific to the input streams, and not the offset in the output.
(In reply to Sebastian Dröge (slomo) from comment #1) > Review of attachment 310473 [details] [review] [review]: > > ::: gst/flv/gstflvmux.c > @@ +1126,3 @@ > + } else { > + GST_BUFFER_OFFSET (tag) = GST_BUFFER_OFFSET (buffer); > + GST_BUFFER_OFFSET_END (tag) = GST_BUFFER_OFFSET_END (buffer); > > Copying the offsets seem not very useful either here. They are going to be > values specific to the input streams, and not the offset in the output. I did not add this, this was already there. I just added copying of timestamps when streamable.
Hmm, true, I should have remove that too. Offset is in FORMAT_DEFAULT, do other muxers convert that to bytes offset ?
Created attachment 311960 [details] [review] additional patch In order for flvdemux to correctly parse the stream, the offsets need to be NONE.
Comment on attachment 311960 [details] [review] additional patch commit b6f133ba1794cdb39cc9c9892785a907b617323a Author: Havard Graff <havard.graff@gmail.com> Date: Tue Sep 22 22:59:16 2015 +0200 flvmux: GST_BUFFER_OFFSETs should be GST_BUFFER_OFFSET_NONE Or else flvdemux don't understand it https://bugzilla.gnome.org/show_bug.cgi?id=754435
Comment on attachment 310473 [details] [review] patch with test commit cf3a2294da194727027d498b85e12ef49fadb440 Author: Havard Graff <havard.graff@gmail.com> Date: Wed Sep 2 10:44:59 2015 +0200 flvmux: use time segment and copy timestamps when streamable Add a basic test using speex data to verify timestamping. https://bugzilla.gnome.org/show_bug.cgi?id=754435
Same change for matroskamux commit ca9b6b55e61a14c448078e8291dc0e9cf3c19dde Author: Sebastian Dröge <sebastian@centricular.com> Date: Sun Oct 11 11:37:51 2015 +0100 matroskamux: Create a TIME segment when creating streamable output Related to https://bugzilla.gnome.org/show_bug.cgi?id=754435 which does the same for flvmux.