GNOME Bugzilla – Bug 754432
curlsink: FTP active connection not handled properly in error case (aborted transfer)
Last modified: 2016-04-14 17:42:59 UTC
This problem has been discovered while testing FTP upload against FileZilla server ,that probably aborts an ongoing transfer in an inappropriate way, however this situation should be handled properly in curlsink. Two problems exist: 1) In the case when the data session has not been established any attempt to its "removal" results in GStreamer-CRITICAL **: gst_poll_remove_fd: assertion 'fd->fd >= 0' failed 2) There is no error message generated when data transfer is aborted by FTP server (FTP server response: 426 Connection closed; transfer aborted). This depends on a bug existing in libcurl, that already has been reported here: https://github.com/bagder/curl/issues/405 1) easy to solve but I'm awaiting a solution to 2) before sending a final fix to this problem
Created attachment 310899 [details] [review] report an unknown error
Please, have a look at the attached patch. Thank you.
Created attachment 311264 [details] [review] report an unknown error
Updated the patch with a comment.
So is this a workaround for a bug in libcurl? If yes, we should put a /* FIXME: remove this again once we can depend on libcurl >= a.b.c, * see $bug_url */ above the code block. Or is it an expected failure mode at this point and will be in future versions (with that libcurl change you linked)?
Created attachment 311373 [details] [review] report an unknown error
Yes, it's a workaround for a bug in libcurl. I've put a FIXME. Thanks!
Looks like this one fell through the cracks, sorry! commit 0fbbbd042a115e2520f7c99d874617d88a711878 Author: Patricia Muscalu <patricia@axis.com> Date: Tue Sep 8 14:37:57 2015 +0200 curlsink: catch an unknown error In this case the socket callback has not been called by libcurl and the curlsink has not been notified about any connection problems by libcurl. This indicates that it's a bug in libcurl so catch it as an unknown error. https://bugzilla.gnome.org/show_bug.cgi?id=754432
Thank you!