GNOME Bugzilla – Bug 754425
fuzzy looking album placeholder icon
Last modified: 2016-10-04 12:33:04 UTC
Created attachment 310455 [details] screenshot The graphics used for the album without a album cover on the right is upscaled and looks a bit blurry.
Is this an HiDPI display? I think we already have a bug filed for that. Not sure if we can fix it - we don't choose the size of thumbnail from last.fm. It might also be some incorrect downscaling on our side though
Yup, it's a hidpi (3200x1800). The thumbnail from lastfm is OK, but the placeholder icon on the right comes from gnome-icon-theme-symbolic I think. https://git.gnome.org/browse/gnome-music/tree/data/NoMusic.ui#n16
Created attachment 324673 [details] [review] Patch for using load_icon_for_scale instead of load_icon Use load_icon_for_scale to show icon for higher dpi
Created attachment 324675 [details] [review] Patch for using load_icon_for_scale instead of load_icon Fix some get_default_icon not using the new format error of previous patch
Created attachment 324862 [details] [review] Using load_icon_for_scale to get hidpi icon for hidpi environment Using git format-patch to generate patch
Review of attachment 324862 [details] [review]: In general I think this patch is on the right track, however I think the scale shouldn't be passed back and forth. Whenever an icon/albumart is requested it should figure out the current scale and use that, so that should be artcache class contained. I guess it's technically possible for scale to shift during run time, not sure if and how we should react to that.
I've added a wip/mschraal/coverart branch on git, which should fix this issue. Please test and report back.
see #7 This problem has been fixed in the unstable development version. The fix will be available in the next major software release. You may need to upgrade your Linux distribution to obtain that newer version.