GNOME Bugzilla – Bug 754420
Translatable strings that should not be translatable
Last modified: 2018-05-22 12:55:30 UTC
I have noticed that there are many translatable strings in Rygel that seem to have no sensible meaning for ordinary users. For example[1]: #. error is only emitted if even the basic information extraction #. failed; there's not much to do here, just print the information and #. go to the next file #: ../src/plugins/media-export/rygel-media-export-harvesting-task.vala:334 #, c-format msgid "Skipping URI %s; extraction completely failed: %s" msgstr "" #: ../src/plugins/media-export/rygel-media-export-item-factory.vala:120 #, c-format msgid "Invalid metadata serialisation, cannot process %s" msgstr "" #: ../src/plugins/media-export/rygel-media-export-item-factory.vala:136 #, c-format msgid "Invalid metadata serialisation: expected 7 children, got %d" msgid_plural "Invalid metadata serialisation: expected 7 children, got %d" msgstr[0] "" msgstr[1] "" Is this something the user can do anything about? Are these even visible to users? If the answer is no, then there is no point in translating them either. A little research shows that these and many similarly confusing strings are in fact coming from the warning()[2] method. Could you remove the translatable mark from these strings? Here is a list of affected files - in total these make up about the third(!) of all translatable strings in the whole project: gabor@gabor-laptop:~/src/gnome/rygel$ grep -rc "warning (_" * | grep -v 0$src/media-engines/gstreamer/rygel-gst-media-engine.vala:3 src/media-engines/gstreamer/rygel-gst-data-source.vala:2 src/media-engines/simple/rygel-simple-media-engine.vala:3 src/librygel-renderer/rygel-av-transport.vala:2 src/librygel-db/database-cursor.vala:1 src/librygel-core/rygel-energy-management-helper.c:3 src/librygel-core/rygel-basic-management.vala:3 src/librygel-core/rygel-log-handler.vala:1 src/librygel-core/rygel-recursive-module-loader.vala:1 src/librygel-core/rygel-basic-management-test.vala:2 src/librygel-core/rygel-plugin-loader.vala:3 src/plugins/tracker/rygel-tracker-plugin-factory.vala:1 src/plugins/tracker/rygel-tracker-category-all-container.vala:1 src/plugins/external/rygel-external-variant-util.vala:1 src/plugins/media-export/rygel-media-export-extract.vala:8 src/plugins/media-export/rygel-media-export-writable-db-container.vala:2 src/plugins/media-export/rygel-media-export-plugin.vala:1 src/plugins/media-export/rygel-media-export-harvesting-task.vala:5 src/plugins/media-export/rygel-media-export-metadata-extractor.vala:9 src/plugins/media-export/rygel-media-export-root-container.vala:2 src/plugins/media-export/rygel-media-export-media-cache.vala:15 src/plugins/media-export/rygel-media-export-trackable-db-container.vala:4 src/plugins/media-export/rygel-media-export-recursive-file-monitor.vala:1 src/plugins/media-export/rygel-media-export-item-factory.vala:8 src/plugins/media-export/rygel-media-export-media-cache-upgrader.vala:4 src/plugins/media-export/rygel-media-export-leaf-query-container.vala:1 src/plugins/media-export/rygel-media-export-node-query-container.vala:1 src/plugins/media-export/rygel-media-export-harvester.vala:4 src/plugins/playbin/rygel-playbin-plugin.vala:1 src/librygel-ruih/rygel-ruih-servicemanager.vala:3 src/librygel-server/rygel-thumbnailer.vala:1 src/librygel-server/rygel-media-file-item.vala:1 src/librygel-server/rygel-media-container.vala:1 src/librygel-server/rygel-object-creator.vala:1 src/librygel-server/rygel-http-post.vala:1 src/librygel-server/rygel-media-art-store.vala:2 src/librygel-server/rygel-import-resource.vala:2 src/librygel-server/rygel-media-object.vala:2 src/librygel-server/rygel-search.vala:1 src/librygel-server/rygel-browse.vala:1 src/librygel-server/rygel-item-updater.vala:1 src/librygel-server/rygel-item-destroyer.vala:1 src/librygel-server/rygel-reference-creator.vala:1 src/rygel/rygel-user-config.vala:1 src/rygel/rygel-cmdline-config.vala:1 src/rygel/rygel-main.vala:3 src/rygel/rygel-acl.vala:2 gabor@gabor-laptop:~/src/gnome/rygel$ grep -rc "warning (ngettext" * | grep -v 0$ src/plugins/media-export/rygel-media-export-item-factory.vala:1 src/rygel/rygel-main.vala:1 [1] https://l10n.gnome.org/POT/rygel.master/rygel.master.pot [2] http://valadoc.org/#!api=glib-2.0/GLib.warning Thanks in advance!
While some (many?) of these strings could be improved to be more end-user-friendly, the decision of whether or not they should be translated, is not at all a simple one. You see these strings are not presented to users by Rygel itself but the UIs using Rygel. Some of them can (and IIRC do?) pressent the provided error messages to user and hence the reason for error messsages sent to clients, being translated.
(In reply to Gabor Kelemen from comment #0) > I have noticed that there are many translatable strings in Rygel that seem > to have no sensible meaning for ordinary users. For example[1]: > > #. error is only emitted if even the basic information extraction > #. failed; there's not much to do here, just print the information and > #. go to the next file > #: ../src/plugins/media-export/rygel-media-export-harvesting-task.vala:334 > #, c-format > msgid "Skipping URI %s; extraction completely failed: %s" > msgstr "" This the user can't do anything about, but he should be aware of and it will be somewhere in a log or on console. > > #: ../src/plugins/media-export/rygel-media-export-item-factory.vala:120 > #, c-format > msgid "Invalid metadata serialisation, cannot process %s" > msgstr "" > > #: ../src/plugins/media-export/rygel-media-export-item-factory.vala:136 > #, c-format > msgid "Invalid metadata serialisation: expected 7 children, got %d" > msgid_plural "Invalid metadata serialisation: expected 7 children, got %d" > msgstr[0] "" > msgstr[1] "" These two are warnings by accident. > Is this something the user can do anything about? Are these even visible to > users? If the answer is no, then there is no point in translating them > either. All of the warnings end up in a log. > > > A little research shows that these and many similarly confusing strings are > in fact coming from the warning()[2] method. > > Could you remove the translatable mark from these strings? Then we can skip translation alltogether. Which is fine. But you people need to decide whether or not. Because we had this before. When I'm ripping out translation this time, it'll be forever.
Created attachment 311254 [details] [review] media-export: Simplify variant checking Signed-off-by: Jens Georg <mail@jensge.org>
Patch removes the offending strings regarding serialisation in media-export plugin. We can do another round of warning message review next cycle
-- GitLab Migration Automatic Message -- This bug has been migrated to GNOME's GitLab instance and has been closed from further activity. You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.gnome.org/GNOME/rygel/issues/91.