After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 754413 - Fix return value error in champlain_view_get_world
Fix return value error in champlain_view_get_world
Status: RESOLVED FIXED
Product: libchamplain
Classification: Core
Component: General
unspecified
Other FreeBSD
: Normal normal
: ---
Assigned To: libchamplain-maint
libchamplain-maint
Depends on:
Blocks:
 
 
Reported: 2015-09-01 17:35 UTC by Ting-Wei Lan
Modified: 2015-09-02 02:42 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Fix return value error in champlain_view_get_world (836 bytes, patch)
2015-09-01 17:36 UTC, Ting-Wei Lan 		none Details | Review

Description Ting-Wei Lan 2015-09-01 17:35:19 UTC 
Please see the patch. champlain_view_get_world has a return value, so it cannot use g_return_if_fail.
Comment 1 Ting-Wei Lan 2015-09-01 17:36:55 UTC 
Created attachment 310440 [details] [review]
Fix return value error in champlain_view_get_world
Comment 2 Jiri Techet 2015-09-01 21:31:11 UTC 
Right, thanks for noticing.

Funny the -Wall switch in gcc doesn't report this, at least on my machine. I guess you used LLVM on FreeBSD which is probably stricter.
Comment 3 Ting-Wei Lan 2015-09-02 02:42:43 UTC 
GCC doesn't report this problem because '#pragma GCC system_header' is used in gmessages.h.
https://bugzilla.gnome.org/show_bug.cgi?id=753310