it would be nice if the row could stay the darker (hover) color while the popover is open, that would provide some visual guidance.

Yeah that could work too.

Created attachment 310677 [details] [review]
Make 'under a popover' themable

This is mainly useful for listbox rows, where the popover might
otherwise point at something that is barely visible.

uhm, maybe we should leave the new style class alone and make the listboxrow retaining the :active (or :checked?) state as buttons do. Looks more consistent to me and should be more familiar for user.

In principle, I agree that using a state for this makes sense. In practice, it is harder to pull off. The styling for :active in listbox rows looks very underwhelming for this purpose - it looks like it expects to be layered on top of :hover. And since the popover is not actually controlled by the row itself, but rather by the sidebar, we have to interfere with the rows own state management, which does not work well. Popover animations make it even harder.

Created attachment 310684 [details] [review]
file chooser: make rows with popovers visible

Without this, the popovers are just dangling in the middle of
nowhere.

The style class would do then, push the patch, I'll take care of making that work on listboxrows in general tomorrow

The last patch is only using the style class on places sidebar rows. not on listbox rows elsewhere. If you want that, you need the first patch that Company deemed 'evil'.

well, let's cure the the real issue, hence the sidebar, I have yet to see this particular problem elsewhere.

boxes list view is another example, but thats custom css territory

Comment on attachment 310684 [details] [review]
file chooser: make rows with popovers visible

Attachment 310684 [details] pushed as 0db331d - file chooser: make rows with popovers visible