After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 754360 - Desktop icons are gone after 610c991c
Desktop icons are gone after 610c991c
Status: RESOLVED FIXED
Product: nautilus
Classification: Core
Component: Desktop
3.17.x
Other Linux
: Normal normal
: ---
Assigned To: Nautilus Maintainers
Nautilus Maintainers
Depends on:
Blocks:
 
 
Reported: 2015-08-31 14:30 UTC by Vadim Rutkovsky
Modified: 2015-09-10 18:20 UTC
See Also:
GNOME target: 3.18
GNOME version: ---


Attachments
desktop: avoid to raise the window on the stack (1.73 KB, patch)
2015-09-10 18:16 UTC, Carlos Soriano
committed Details | Review

Description Vadim Rutkovsky 2015-08-31 14:30:23 UTC
Since Continuous 20150828.55 (https://git.gnome.org/browse/nautilus/commit/?id=610c991c) gnome-classic icons are gone and Gnome Initial Setup is started minimized
Comment 2 Carlos Soriano 2015-09-10 10:16:13 UTC
Vadim this was gnome-shell and is this okay already right? Feel free to reopen if not
Comment 3 Vadim Rutkovsky 2015-09-10 11:05:15 UTC
I can still see this on Continuous: http://build.gnome.org/continuous/buildmaster/builds/2015/09/10/15/smoketest-classic/work-gnome-continuous-x86_64-runtime/screenshot-final.png

Will check if this happens on Rawhide though
Comment 4 Carlos Soriano 2015-09-10 15:09:05 UTC
confirmed downstream https://bodhi.fedoraproject.org/updates/FEDORA-2015-15127
Comment 5 Carlos Soriano 2015-09-10 18:16:23 UTC
Created attachment 311098 [details] [review]
desktop: avoid to raise the window on the stack

If we don't pass DONT_MAKE_ACTIVE flag to the window, it will
raise the window with a gtk_present_window () call, which will
actually hide the desktop window from the background.

This fixes the icons not appearing until the next map () of the
desktop window, that lowers again the window on the stack.
Comment 6 Carlos Soriano 2015-09-10 18:19:16 UTC
As you can guess, my test were always like: enable desktop icons -> go to another workspace that is empty so I can see the icons. So what happened? the desktop window was mapped and we override that to lower the window in the stack, which hides the bug.
That's why I couldn't reproduce it...
Comment 7 Carlos Soriano 2015-09-10 18:20:26 UTC
Attachment 311098 [details] pushed as 34ac469 - desktop: avoid to raise the window on the stack