After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 754344 - libs: build rtp after audio
libs: build rtp after audio
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-base
git master
Other Linux
: Normal blocker
: 1.6.0
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2015-08-31 08:50 UTC by Håvard Graff (hgr)
Modified: 2015-09-04 09:01 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
patch (921 bytes, patch)
2015-08-31 08:50 UTC, Håvard Graff (hgr)
committed Details | Review
The offending Makefile on my system (32.84 KB, text/plain)
2015-08-31 09:06 UTC, Håvard Graff (hgr)
  Details
libs: the rtp dir is no longer an independent subdir (760 bytes, patch)
2015-08-31 09:50 UTC, Tim-Philipp Müller
committed Details | Review

Description Håvard Graff (hgr) 2015-08-31 08:50:39 UTC
Created attachment 310333 [details] [review]
patch

The dependency setup does not seem to work for all systems, causing
the build to fail with:

gstrtpbaseaudiopayload.c:65:0:
fatal error: gst/audio/audio-enumtypes.h: No such file or directory

My setup:
gcc (Ubuntu 4.8.4-2ubuntu1~14.04) 4.8.4
autoconf (GNU Autoconf) 2.69
automake (GNU automake) 1.14.1
libtool (GNU libtool) 2.4.2
Comment 1 Håvard Graff (hgr) 2015-08-31 09:06:23 UTC
Created attachment 310335 [details]
The offending Makefile on my system

Attaching the generated Makefile in case that provides any clues on why this is not working.
Comment 2 Tim-Philipp Müller 2015-08-31 09:50:42 UTC
Created attachment 310336 [details] [review]
libs: the rtp dir is no longer an independent subdir

Try this?
Comment 3 Håvard Graff (hgr) 2015-08-31 09:59:38 UTC
(In reply to Tim-Philipp Müller from comment #2)
> Created attachment 310336 [details] [review] [review]
> libs: try harder to make sure audio subdir gets built before rtp
> 
> Try this?

Tried it. Did not work :(
Comment 4 Sebastian Dröge (slomo) 2015-09-02 16:09:45 UTC
So... what should we do? :)
Comment 5 Tim-Philipp Müller 2015-09-02 16:22:51 UTC
Håvard's patch looks obviously correct (but does it fix the problem?).

My patch also looks obviously correct, but doesn't seem to help :)
Comment 6 Tim-Philipp Müller 2015-09-03 10:37:40 UTC
hgr said on irc that his patch fixes the problem for him.

IMHO both patches should go in (my understanding is that mine doesn't break anything for him either, it's just not enough on its own to fix it for him).
Comment 7 Tim-Philipp Müller 2015-09-04 08:54:47 UTC
Well, let's just get it in and see what happens, shouldn't make anything worse.

commit 181845ec1bc1761002c0c4253561658bddfb71ae
Author: Havard Graff <havard.graff@gmail.com>
Date:   Mon Aug 31 10:46:43 2015 +0200

    libs: build rtp after audio
    
    The dependency setup does not seem to work for all systems,
    causing the build to fail with:
    
    gstrtpbaseaudiopayload.c:65:0:
    fatal error: gst/audio/audio-enumtypes.h: No such file or directory
    
    My setup:
    gcc (Ubuntu 4.8.4-2ubuntu1~14.04) 4.8.4
    autoconf (GNU Autoconf) 2.69
    automake (GNU automake) 1.14.1
    libtool (GNU libtool) 2.4.2
    
    https://bugzilla.gnome.org/show_bug.cgi?id=754344

commit c8ce5765a05d0a6b1bd1a9f1500bc14b8c324343
Author: Tim-Philipp Müller <tim@centricular.com>
Date:   Mon Aug 31 10:49:41 2015 +0100

    libs: rtp is no longer an independent subdir
    
    https://bugzilla.gnome.org/show_bug.cgi?id=754344