After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 754323 - [PATCH] Properties shouldn't be translated
[PATCH] Properties shouldn't be translated
Status: RESOLVED FIXED
Product: gnome-dictionary
Classification: Core
Component: general
unspecified
Other Linux
: Normal normal
: ---
Assigned To: gnome-dictionary-maint
gnome-dictionary-maint
Depends on:
Blocks:
 
 
Reported: 2015-08-30 19:31 UTC by Piotr Drąg
Modified: 2015-09-01 22:57 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Don't translate properties (10.10 KB, patch)
2015-08-31 12:55 UTC, Piotr Drąg
committed Details | Review

Description Piotr Drąg 2015-08-30 19:31:38 UTC
Many strings in gnome-dictionary are properties, which are invisible in the user interface (visible only in developer tools like Glade and gtk-inspector), and therefore shouldn't be marked for translation. It's unnecessary work for translators, and no other app in GNOME does that.
Comment 1 Piotr Drąg 2015-08-31 12:55:57 UTC
Created attachment 310352 [details] [review]
Don't translate properties

This patch removes the translation markers from the properties and removes files now without translations from POTFILES.in.
Comment 2 Christian Hergert 2015-08-31 21:11:12 UTC
Attachment 310352 [details] pushed as e057699 - Don't translate properties
Comment 3 Piotr Drąg 2015-08-31 21:31:31 UTC
This is gnome-dictionary, not gnome-builder. :)
Comment 4 Christian Hergert 2015-08-31 21:39:42 UTC
Very strange, all I did was a `git bz push` with the patch from the other project!
Comment 5 Piotr Drąg 2015-08-31 22:04:21 UTC
Could you try to mark the review of this patch as "none"? Bugzilla throws an error at me...
Comment 6 Emmanuele Bassi (:ebassi) 2015-09-01 22:57:36 UTC
Attachment 310352 [details] pushed as 07f4793 - Don't translate properties