Created attachment 310306 [details] [review]
Temporarily remove the Software Sources dialog

Review of attachment 310306 [details] [review]:

What happens to the translations of the commented out string? I guess they drop out of the generated .po files? If that's the case, can you hack around this somehow so that we don't lose the translations?

Created attachment 310315 [details] [review]
Temporarily remove the Software Sources dialog

Good thinking.

Created attachment 310316 [details] [review]
Temporarily remove the Software Sources dialog

(Forgot to 'git add' before submitting the last patch :)

Review of attachment 310316 [details] [review]:

I am a bit sad have to drop this, but you are right. I agree this is the way to go for now until we make this work well. Right now it's just an accident waiting to happen that could lead to a user removing half of the packages on their system along with a 3rd party repo.

+1 from me.

We are in UI freeze now though - can you run this past the release team as well, please?

I'm not convinced by the premise. No actual dangers are listed in the bug.

And I'm quite dubious about the claim - if you have third-party repositories enabled that silently replace packages deep enough in the dependency chain to remove "all of gnome", then things were already broken on your system before, the breakage just hadn't become apparent yet.

If we let 3rd party repositories do that, then we can't provide any level of trust while managing updates, and could just as well remove gnome-software altogether.

(In reply to Matthias Clasen from comment #7)
> If we let 3rd party repositories do that, then we can't provide any level of
> trust while managing updates, and could just as well remove gnome-software
> altogether.

We already let third party repositories do that. Specific examples of repositories that have caused the software sources dialog to uninstall GNOME:

https://copr.fedoraproject.org/coprs/rhughes/f20-gnome-3-12/
https://copr.fedoraproject.org/coprs/spot/chromium/ (I think because it replaced libusbx)

I'm absolutely in favor of prohibiting repositories from doing this, but that would require buy-in and technical coordination with copr and dnf (considering only Fedora here).

In the meantime, we need this to not happen again.

Richard is looking into adding the ability to simulate a remove repo operation in PackageKit. Then we can use that to trawl the list of packages that would be removed and look for no-nos like gnome-shell, gdm, xorg-x11-server-Xorg (I would add those to the core moduleset), plus all the packages in the system moduleset, and make the remove button insensitive if they're present. Then it would be safe to bring back this dialog, IMO.

Now, I absolutely agree with you that repos shouldn't be replacing core packages in the first place. But users can use dnf or manually edit /etc/yum.repos.d to enable whatever repos they want. I wonder how hard it would be to add checks in gnome-software and dnf to prevent the installation of such repos?

So... if we're not going to take this after all, we should at least remove the Remove button? I have not once ever seen the Remove button work properly, it either uninstalls my desktop or just fails to do anything....

I thought we did. Didn't Kalev work on patches for this a while ago ?

Well this bug is still open, and if he did, they didn't make it into gnome-software-3.18.0-1.fc23....

In other news, the button actually worked when I used it to disable a (harmless) repo just now. That's a good improvement!

Any update on this, Kalev?

You should change my patch's status to something other than accepted, if you don't want me to push it. :)

Bug #732406 is still open, and this patch is still marked as accepted, so I'm going to commit this.

(On a less-serious note: today when I removed a repo (Google Talk plugin), it did no horrible damage, but also claimed I had no software installed from that repo (wrong) and failed to uninstall the plugin....)

Attachment 310316 [details] pushed as cbc5567 - Temporarily remove the Software Sources dialog

I disagree with this

what happened to simply making this dialog readonly ? Not providing any information about installed repositories is not acceptable.

(In reply to Matthias Clasen from comment #17)
> what happened to simply making this dialog readonly ?

Nobody ever made it happen.

Created attachment 319165 [details] [review]
Revert "Temporarily remove the Software Sources dialog"

This reverts commit cbc5567f539ba44f3d7732a956f1452bcf88daa3.

Created attachment 319166 [details] [review]
software-sources: Temporarily remove the remove button

The previous commit which removed the entire dialog was overkill. The
entire dialog is not dangerous; only the remove button is.

While at this, see also: bug 726819.

I have an old patch lying around that kills the repo removal feature and replaces it with enable/disable, leaving the .repo files in place and just editing them. https://kalev.fedorapeople.org/software-sources-on-off.png and a on/off button in the dialog when clicking on the row.

Michael, do you think that would be an improvement?

Created attachment 319439 [details]
android example

As requested by kalev on IRC, an andorid example of a selectable row + checkbox.

(In reply to Kalev Lember from comment #22)
> I have an old patch lying around that kills the repo removal feature and
> replaces it with enable/disable, leaving the .repo files in place and just
> editing them. https://kalev.fedorapeople.org/software-sources-on-off.png and
> a on/off button in the dialog when clicking on the row.
> 
> Michael, do you think that would be an improvement?

Absolutely. Very little can go wrong if you simply disable the repo. Then we don't have to worry about it uninstalling GNOME.

Comment on attachment 319166 [details] [review]
software-sources: Temporarily remove the remove button

committed, thanks.

Comment on attachment 319165 [details] [review]
Revert "Temporarily remove the Software Sources dialog"

committed, thanks.