After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 754250 - decoder: hevc: remove unused functions
decoder: hevc: remove unused functions
Status: RESOLVED FIXED
Product: gstreamer-vaapi
Classification: Other
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: gstreamer-vaapi maintainer(s)
gstreamer-vaapi maintainer(s)
Depends on:
Blocks: 750547
 
 
Reported: 2015-08-28 15:27 UTC by Víctor Manuel Jáquez Leal
Modified: 2015-08-31 11:16 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
decoder: hevc: remove unused functions (2.41 KB, patch)
2015-08-28 15:28 UTC, Víctor Manuel Jáquez Leal 		committed Details | Review

Description Víctor Manuel Jáquez Leal 2015-08-28 15:27:58 UTC 
These functions are not used, and clang complains about them. I'm not sure
if they are not called by mistake or they are not required at all. Sree?
Comment 1 Víctor Manuel Jáquez Leal 2015-08-28 15:28:03 UTC 
Created attachment 310202 [details] [review]
decoder: hevc: remove unused functions

Signed-off-by: Víctor Manuel Jáquez Leal <victorx.jaquez@intel.com>
Comment 2 sreerenj 2015-08-28 20:22:24 UTC 
Review of attachment 310202 [details] [review]:

::: gst-libs/gst/vaapi/gstvaapidecoder_h265.c
@@ -592,3 @@
-  return pi ? &pi->data.vps : NULL;
-}
-  return pi ? &pi->data.vps : NULL;

VPS nal is not necessary to decode the base layers, so this is not needed at the moment. But in future we need this, especially when dealing with MVC and scalable layer decoding... 
Please add a a "#if 0" instead of removing the code...

@@ -1359,3 @@
-  *PicHeightInCtbsY =
-      ceil ((double) sps->pic_height_in_luma_samples / (double) CtbSizeY);
-  MinCbLog2SizeY = sps->log2_min_luma_coding_block_size_minus3 + 3;

This piece of code was necessary before when there was no proper tile row and column parsing support in codecparsers. But this has been added recently in codecparser library and I forgot to remove this function from gstvaapidecoder...
Yes this is redundant , please remove.
Comment 3 sreerenj 2015-08-28 20:22:25 UTC 
Review of attachment 310202 [details] [review]:

::: gst-libs/gst/vaapi/gstvaapidecoder_h265.c
@@ -592,3 @@
-  return pi ? &pi->data.vps : NULL;
-}
-  return pi ? &pi->data.vps : NULL;

VPS nal is not necessary to decode the base layers, so this is not needed at the moment. But in future we need this, especially when dealing with MVC and scalable layer decoding... 
Please add a a "#if 0" instead of removing the code...

@@ -1359,3 @@
-  *PicHeightInCtbsY =
-      ceil ((double) sps->pic_height_in_luma_samples / (double) CtbSizeY);
-  MinCbLog2SizeY = sps->log2_min_luma_coding_block_size_minus3 + 3;

This piece of code was necessary before when there was no proper tile row and column parsing support in codecparsers. But this has been added recently in codecparser library and I forgot to remove this function from gstvaapidecoder...
Yes this is redundant , please remove.
Comment 4 Víctor Manuel Jáquez Leal 2015-08-31 11:14:11 UTC 
Attachment 310202 [details] pushed as cc63452 - decoder: hevc: remove unused functions
Comment 5 Víctor Manuel Jáquez Leal 2015-08-31 11:14:58 UTC 
Pushed with the required modification.