After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 754247 - vc1parse: add break to switch case
vc1parse: add break to switch case
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-bad
git master
Other Linux
: Normal normal
: 1.7.1
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2015-08-28 15:17 UTC by Luis de Bethencourt
Modified: 2015-09-29 12:41 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
patch (894 bytes, patch)
2015-08-28 15:17 UTC, Luis de Bethencourt
committed Details | Review

Description Luis de Bethencourt 2015-08-28 15:17:40 UTC
Created attachment 310199 [details] [review]
patch

Even though all cases inside VC1_STREAM_FORMAT_ASF are goto or
g_assert_not_reached(), add a break at the end to appease Coverity.
Comment 1 Luis de Bethencourt 2015-08-28 15:18:17 UTC
Review of attachment 310199 [details] [review]:

Better to wait until after freeze.
Comment 2 Luis de Bethencourt 2015-09-29 12:34:46 UTC
Review of attachment 310199 [details] [review]:

commit c8d4e85f9e88d0e1786a2f5fcb07b2fa785346bf
Author: Luis de Bethencourt <luis@debethencourt.com>
Date:   Fri Aug 28 16:13:16 2015 +0100

    vc1parse: add break to switch case

    Even though all cases inside VC1_STREAM_FORMAT_ASF are goto or
    g_assert_not_reached(), add a break at the end to appease Coverity.

    CID #1320706