After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 754215 - wayland: Clean up surface role assignment
wayland: Clean up surface role assignment
Status: RESOLVED FIXED
Product: mutter
Classification: Core
Component: wayland
unspecified
Other All
: Normal normal
: ---
Assigned To: mutter-maint
mutter-maint
Depends on:
Blocks:
 
 
Reported: 2015-08-28 04:42 UTC by Jonas Ådahl
Modified: 2015-09-07 09:44 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
wayland: Clean up surface role assignment (9.09 KB, patch)
2015-08-28 04:42 UTC, Jonas Ådahl 		committed Details | Review

Description Jonas Ådahl 2015-08-28 04:42:36 UTC 
Usea better name, use GNOME conventions for error handling, open code the
client error reporting and send the error to the correct resource.
wl_subcompositor doesn't have a role error yet, so continue use some
other error. The only effect of this is error received in the client will
be a bit confusing, it will still be disconnected.
Comment 1 Jonas Ådahl 2015-08-28 04:42:43 UTC 
Created attachment 310150 [details] [review]
wayland: Clean up surface role assignment
Comment 2 Owen Taylor 2015-09-03 20:02:07 UTC 
Review of attachment 310150 [details] [review]:

This looks like an improvement from me. I wouldn't have objected to keeping the wayland-error reporting in the function to avoid duplication, but I do like the fact that this we keep the wayland error reporting right in the wayland protocol handlers where it is clearer what is going on.
Comment 3 Jonas Ådahl 2015-09-07 09:44:01 UTC 
Attachment 310150 [details] pushed as 9451372 - wayland: Clean up surface role assignment