After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 754180 - audiobasesrc/ringbuffer: Uses too small integers for segment counters
audiobasesrc/ringbuffer: Uses too small integers for segment counters
Status: RESOLVED OBSOLETE
Product: GStreamer
Classification: Platform
Component: gst-plugins-base
git master
Other Linux
: Normal major
: git master
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on: 754182
Blocks:
 
 
Reported: 2015-08-27 14:22 UTC by Sebastian Dröge (slomo)
Modified: 2018-11-03 11:40 UTC
See Also:
GNOME target: ---
GNOME version: ---


Description Sebastian Dröge (slomo) 2015-08-27 14:22:33 UTC 
See https://github.com/EricssonResearch/openwebrtc/pull/456 for some discussion. Problem is this code: http://cgit.freedesktop.org/gstreamer/gst-plugins-base/tree/gst-libs/gst/audio/gstaudiobasesrc.c#n927

running_time_segment is only an integer (as required by g_atomic_int_*), and will overflow after a while. And it will cause problems immediately if having a huge running time, e.g. when explicitly setting base_time=0 and having a clock with a high current time.


Not sure yet how to fix this as the segment counters are part of the public API unfortunately, and also there are not atomic ops on 64 bit integers.
Comment 1 Nirbheek Chauhan 2015-08-27 15:49:09 UTC 
(In reply to Sebastian Dröge (slomo) from comment #0)
> Not sure yet how to fix this as the segment counters are part of the public
> API unfortunately, and also there are not atomic ops on 64 bit integers.

The GLib API is deficient in this, but gcc and mingw/msvc do support this. I filed bug 754182 about that.
Comment 2 GStreamer system administrator 2018-11-03 11:40:47 UTC 
-- GitLab Migration Automatic Message --

This bug has been migrated to freedesktop.org's GitLab instance and has been closed from further activity.

You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.freedesktop.org/gstreamer/gst-plugins-base/issues/217.