GNOME Bugzilla – Bug 754130
class="current" not applied to <li> for module tab within 'group__*.html' module html files
Last modified: 2016-02-10 17:21:57 UTC
The behavior of the pages tab in the horizontal tab bar doesn't seem to be replicated in the modules tab: 1. Select related pages 2. Select a link to a page 3. Observe that the 'related pages' <li> entry is <li class="current> as defined in templates/html/htmltabs.tpl, presumably since page.highlight=='pages'. For the problem case: 1. Select Modules 2. Select a link to a module 3. Observe that the 'modules' <li> entry is simply <li>, and in fact no tabs have class="current" applied, even though htmltabs.tpl seems to apply this class when page.highlight=='modules'. Result: Tab look and feel is inconsistent and the user loses context of where they are in the documentation. Css cannot alter the current tab's look for module pages. I tried to investigate this, but actually nothing I did in the htmltabs.tpl file seemed to have any effect. Even plain html tags outside of the {% if %} blocks to this template file did not propagate to the html generated. If you can give me some pointers, I can look into this. It seems that page.highlight=='modules' is only getting applied for the module listing page, and not for the individual 'group__*.html' module pages. I suspect this has to do with the implementation or calling of a function in src/context.cpp
Hi Eric, Don't look at any of the .tpl files or the code in context.cpp or template.cpp. This is for doxygen 2.0 and is not used yet! I think the issue is: void GroupDef::writeDocumentation(OutputList &ol) { //static bool generateTreeView = Config_getBool("GENERATE_TREEVIEW"); ol.pushGeneratorState(); startFile(ol,getOutputFileBase(),name(),title,HLI_None); ... where the HLI_None should have been HLI_Modules. Can you check if that works?
Yes, that does indeed work. Thanks! And thanks for clearing up the .tpl file issue. I thought I was going crazy there for a minute :) Would you like me to submit a pull request or is there a test suite you run these changes through first?
pull request is not needed. It is such a small change that I've committed it myself. Just wanted to be sure it actually fixes your problem.
This bug was previously marked ASSIGNED, which means it should be fixed in doxygen version 1.8.11. Please verify if this is indeed the case. Reopen the bug if you think it is not fixed and please include any additional information that you think can be relevant (preferably in the form of a self-contained example).
I can confirm this is fixed, and is working properly in 1.8.11. Sorry for the late confirmation.