After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 754116 - [PATCH] git: fix current branch detection
[PATCH] git: fix current branch detection
Status: RESOLVED FIXED
Product: jhbuild
Classification: Infrastructure
Component: general
unspecified
Other Linux
: Normal normal
: ---
Assigned To: Jhbuild maintainers
Jhbuild QA
Depends on:
Blocks:
 
 
Reported: 2015-08-26 12:25 UTC by Maciek Borzecki
Modified: 2015-08-27 08:30 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
[PATCH] git: fix current branch detection (1.63 KB, patch)
2015-08-26 12:25 UTC, Maciek Borzecki 		accepted-commit_now Details | Review

Description Maciek Borzecki 2015-08-26 12:25:33 UTC 
Created attachment 310028 [details] [review]
[PATCH] git: fix current branch detection

The current branch name will be incorrect if threre's a slash in it. For
instance, if one uses a branch naming pattern like 'foo/master',
get_current_branch() will incorrectly return 'master'.

The problem is addressed in the attached patch.
Comment 1 Frederic Peters 2015-08-27 06:44:25 UTC 
Comment on attachment 310028 [details] [review]
[PATCH] git: fix current branch detection

Thanks, go ahead and push it.
Comment 2 Maciek Borzecki 2015-08-27 07:56:35 UTC 
(In reply to Frederic Peters from comment #1)
> Comment on attachment 310028 [details] [review] [review]
> [PATCH] git: fix current branch detection
> 
> Thanks, go ahead and push it.

I don't have commit rights. Would you be able to push it?