GNOME Bugzilla – Bug 754094
[PLUGIN-MOVE] move gtk + qml plugins to -good
Last modified: 2018-02-12 19:03:03 UTC
Within 1.7 development branch, it would be nice to start looking at the GstGL API. Reviewing, removing anything that is not strictly needed and making API consistent. An example API that could be removed is gst_upload_release_buffer(), this could remain internal, having to explictly release an internal buffer makes very little sense with the few refactoring that happened. There is other places where we may want to improve the API.
Is there anything specific you're looking to change now?
Repurposing for the move to -base :)
What's the status of this now? Is gl ready to be moved? Both plugin and lib? Is the lib API okay to be stable? Do we have padding in public structs? Documentation?
Yes to all of those. The only thing that may be needed is a last look over the documentation. I would like another set of eyes to have a look though and double check all of that.
Hi Matthew, what about: /* FIXME: remove */ GST_EXPORT void gst_gl_context_thread_add (GstGLContext * context, GstGLContextThreadFunc func, gpointer data); ? Also I think all TODO/FIXME field should be moved to .c instead of h. Cheers Julien
That's not going away anytime soon unfortunately. Fixing that is measured in months of effort is effectively a rewrite of *everything*.
All of the FIXME/TODO's in the header files will either be removed on moving to -base or don't really make sense in the .c files.
Also a quick way to find nits are using these 2 links: https://gstreamer.freedesktop.org/data/doc/gstreamer/head/gst-plugins-bad-libs/html/gl.html https://gstreamer.freedesktop.org/data/doc/gstreamer/head/gst-plugins-bad-plugins/html/ I think for elements that already existed in 0.10, the pipeline example on top of the .c file should be updated or does not work (see glfilterglass for example, the mentioned pipeline gets stuck or see https://gstreamer.freedesktop.org/data/doc/gstreamer/head/gst-plugins-bad-plugins/html/gst-plugins-bad-plugins-glimagesink.html the text should be deleted or at least now FBO is required always) Here: https://gstreamer.freedesktop.org/data/doc/gstreamer/head/gst-plugins-bad-libs/html/gst-plugins-bad-libs-GstGLAPI.html GST_GL_API_GLES1_NAME ->GST_GL_API_NAME_GLES1 etc... Missing title next to GstGLDisplayWayland /X11 on pagehttps://gstreamer.freedesktop.org/data/doc/gstreamer/head/gst-plugins-bad-libs/html/gl.html Sorry I cannot do more at the moment.
Thanks for the comments :). docs can always be changed/added later. This is more about the API/ABI interface which once set, cannot change. Also, a FBO isn't required for uploading RGBA buffers so that comment is still valid. Currently the lower limitation on the OpenGL version is on requiring OpenGL shaders.
What's blocking this move? The latest stable release of webkitgtk (2.18) uses gstreamergl by default. Because Ubuntu won't include the -bad plugins by default, Ubuntu has to disable that support which is strongly discouraged by the webkitgtk developers.
Last checks, thumbs up from Matt. Still planned for this cycle landing in 1.14 (which should be out in time for 18.04).
gstgl is now in -base - retitling (since I can't be bothered to clone new bugs). Not sure what the state of gtk / qml is.
Should be fine to move both. The API of the elements is simple enough not it seems safe to stabilize. They work and they probably have bugs like all other code.
Should IMHO also happen before 1.14
Done.