After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 754083 - wrong vi modelines in multiple commander plugin files
wrong vi modelines in multiple commander plugin files
Status: RESOLVED FIXED
Product: gedit-plugins
Classification: Other
Component: General
3.14.x
Other Linux
: Normal normal
: ---
Assigned To: Matěj Cepl
Gedit maintainers
Depends on:
Blocks:
 
 
Reported: 2015-08-25 14:08 UTC by Matěj Cepl
Modified: 2019-03-23 20:54 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
suggested patch (13.06 KB, patch)
2015-08-25 14:08 UTC, Matěj Cepl
none Details | Review
Fix vi modelines (13.28 KB, patch)
2015-08-25 14:39 UTC, Matěj Cepl
none Details | Review

Description Matěj Cepl 2015-08-25 14:08:09 UTC
Created attachment 309968 [details] [review]
suggested patch

Modeline

# vi:ex:ts=4:et

is wrong. It should either with vi: or ex:, but not both.

See http://vimhelp.appspot.com/options.txt.html#auto-setting
Comment 1 Matěj Cepl 2015-08-25 14:19:52 UTC
nacho: yeah just for consistency with other files
nacho: maybe check what it is used on the other py files
nacho: and use the saame
Comment 2 Matěj Cepl 2015-08-25 14:33:01 UTC
OK, we have ex: everywhere:

$ grep -r -E '(vi|ex):' --include=\*.py
plugins/bracketcompletion/bracketcompletion.py:# ex:ts=4:et:
plugins/charmap/charmap/panel.py:# ex:et:ts=4:
plugins/charmap/charmap/__init__.py:# ex:et:ts=4:
plugins/codecomment/codecomment.py:# ex:ts=4:et:
plugins/colorpicker/colorpicker.py:# ex:ts=4:et:
plugins/commander/commander/commands/metamodule.py:# vi:ts=4:et
plugins/commander/commander/commands/__init__.py:# vi:ex:ts=4:et
plugins/commander/commander/commands/accel_group.py:# vi:ex:ts=4:et
plugins/commander/commander/commands/completion.py:# vi:ex:ts=4:et
plugins/commander/commander/commands/exceptions.py:# vi:ex:ts=4:et
plugins/commander/commander/commands/method.py:# vi:ex:ts=4:et
plugins/commander/commander/commands/module.py:# vi:ex:ts=4:et
plugins/commander/commander/commands/result.py:# vi:ex:ts=4:et
plugins/commander/commander/commands/rollbackimporter.py:# vi:ex:ts=4:et
plugins/commander/commander/__init__.py:# vi:ex:ts=4:et
plugins/commander/commander/appactivatable.py:# vi:ex:ts=4:et
plugins/commander/commander/entry.py:# vi:ex:ts=4:et
plugins/commander/commander/history.py:# vi:ex:ts=4:et
plugins/commander/commander/info.py:# vi:ex:ts=4:et
plugins/commander/commander/modules.py:# vi:ex:ts=4:et
plugins/commander/commander/utils.py:# vi:ex:ts=4:et
plugins/commander/commander/windowactivatable.py:# vi:ex:ts=4:et
plugins/commander/modules/find/__init__.py:# vi:ex:ts=4:et
plugins/commander/modules/find/finder.py:# vi:ex:ts=4:et
plugins/commander/modules/find/regex.py:# vi:ex:ts=4:et
plugins/commander/modules/grep.py:# vi:ts=4:et
plugins/commander/modules/align.py:        reg, words, modifier = (yield commander.commands.result.Prompt('Regex:'))
plugins/commander/modules/align.py:# vi:ex:ts=4:et
plugins/commander/modules/bookmark.py:# vi:ex:ts=4:et
plugins/commander/modules/doc.py:# vi:ex:ts=4:et
plugins/commander/modules/edit.py:# vi:ts=4:et
plugins/commander/modules/edit.py:# vi:ex:ts=4:et
plugins/commander/modules/format.py:# vi:ex:ts=4:et
plugins/commander/modules/goto.py:# vi:ex:ts=4:et
plugins/commander/modules/help.py:# vi:ex:ts=4:et
plugins/commander/modules/move.py:    """Move cursor per regex: move.regex <num>
plugins/commander/modules/move.py:# vi:ex:ts=4:et
plugins/commander/modules/reload.py:# vi:ex:ts=4:et
plugins/commander/modules/set.py:# vi:ex:ts=4:et
plugins/commander/modules/shell.py:# vi:ex:ts=4:et
plugins/dashboard/dashboard/__init__.py:# ex:ts=4:et:
plugins/dashboard/dashboard/dashboard.py:# ex:ts=4:et:
plugins/git/git/workerthread.py:# ex:ts=4:et:
plugins/git/git/diffrenderer.py:# ex:ts=4:et:
plugins/git/git/appactivatable.py:# ex:ts=4:et:
plugins/git/git/debug.py:# ex:ts=4:et:
plugins/git/git/windowactivatable.py:# ex:ts=4:et:
plugins/git/git/__init__.py:# ex:ts=4:et:
plugins/git/git/viewactivatable.py:# ex:ts=4:et:
plugins/joinlines/joinlines.py:# ex:ts=4:et:
plugins/multiedit/multiedit/signals.py:# ex:ts=4:et:
plugins/multiedit/multiedit/__init__.py:# ex:ts=4:et:
plugins/multiedit/multiedit/appactivatable.py:# ex:ts=4:et:
plugins/multiedit/multiedit/viewactivatable.py:        if not regex:
plugins/multiedit/multiedit/viewactivatable.py:                if regex:
plugins/multiedit/multiedit/viewactivatable.py:# ex:ts=4:et:
plugins/multiedit/multiedit/windowactivatable.py:# ex:ts=4:et:
plugins/smartspaces/smartspaces.py:# ex:ts=4:et:
plugins/synctex/synctex/evince_dbus.py:# ex:ts=4:et:
plugins/synctex/synctex/synctex.py:# ex:ts=4:et:
plugins/terminal/terminal.py:# ex:ts=4:et:
plugins/textsize/textsize/__init__.py:# ex:ts=4:et:
plugins/textsize/textsize/signals.py:# ex:ts=4:et:
plugins/textsize/textsize/viewactivatable.py:# ex:ts=4:et:
$
Comment 3 Matěj Cepl 2015-08-25 14:39:54 UTC
Created attachment 309970 [details] [review]
Fix vi modelines

Modeline

   # vi:ex:ts=4:et

is wrong. It should either with vi: or ex:, but not both.
Comment 4 Matěj Cepl 2015-08-25 14:42:54 UTC
Commited in ea2f115 in master, e8c31ad in gnome-3-14