After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 754079 - Huge spinner while loading
Huge spinner while loading
Status: RESOLVED FIXED
Product: gnome-documents
Classification: Core
Component: general
3.17.x
Other All
: Normal normal
: ---
Assigned To: GNOME documents maintainer(s)
GNOME documents maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2015-08-25 13:14 UTC by Alessandro Bono
Modified: 2015-08-27 09:30 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
huge-spinner (1.44 MB, image/png)
2015-08-25 13:14 UTC, Alessandro Bono 		  Details
embed: Reduce icon size to 32 pixels (690 bytes, patch)
2015-08-25 13:18 UTC, Alessandro Bono 		committed Details | Review
embed: Use only GtkSpinner (3.99 KB, patch)
2015-08-25 13:18 UTC, Alessandro Bono 		committed Details | Review

Description Alessandro Bono 2015-08-25 13:14:31 UTC 
Created attachment 309960 [details]
huge-spinner

As pointed out by Allan on IRC, the spinner should be 32x32 pixels
Comment 1 Alessandro Bono 2015-08-25 13:18:05 UTC 
Created attachment 309961 [details] [review]
embed: Reduce icon size to 32 pixels
Comment 2 Alessandro Bono 2015-08-25 13:18:51 UTC 
Created attachment 309962 [details] [review]
embed: Use only GtkSpinner

Since we are using SpinnerBox only to contain the GtkSpinner,
we can remove it
Comment 3 Cosimo Cecchi 2015-08-25 16:13:49 UTC 
Review of attachment 309962 [details] [review]:

Looks good to me.
Comment 4 Cosimo Cecchi 2015-08-25 16:13:58 UTC 
Review of attachment 309961 [details] [review]:

Looks good to me
Comment 5 Debarshi Ray 2015-08-26 07:32:52 UTC 
Out of general curiosity, did spinners in gtk+ become large again? They had gotten smaller in 3.12 (see bug 723729). How do they change sizes all by themselves?
Comment 6 Debarshi Ray 2015-08-26 07:57:18 UTC 
Comment on attachment 309961 [details] [review]
embed: Reduce icon size to 32 pixels

Pushed to master. Alessandro, you could ask for access to git.gnome.org. :)
Comment 7 Debarshi Ray 2015-08-26 08:08:12 UTC 
Comment on attachment 309962 [details] [review]
embed: Use only GtkSpinner

Pushed to master.