After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 754078 - GDBus: guint filter IDs can overflow
GDBus: guint filter IDs can overflow
Status: RESOLVED OBSOLETE
Product: glib
Classification: Platform
Component: gdbus
unspecified
Other Linux
: Normal normal
: ---
Assigned To: David Zeuthen (not reading bugmail)
gtkdev
Depends on: 704568
Blocks:
 
 
Reported: 2015-08-25 12:52 UTC by Colin Walters
Modified: 2018-05-24 18:10 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
handle overflow of filter ids (73 bytes, patch)
2015-08-25 12:53 UTC, Colin Walters 		needs-work Details | Review

Description Colin Walters 2015-08-25 12:52:46 UTC 
+++ This bug was initially created as a clone of Bug #704568 +++

Taking the overflow issue from the above bug.
Comment 1 Colin Walters 2015-08-25 12:53:47 UTC 
Created attachment 309959 [details] [review]
handle overflow of filter ids
Comment 2 Colin Walters 2015-08-25 12:54:12 UTC 
 Colin Walters [developer] 2015-08-24 16:38:55 EDT

Review of attachment 309733 [details] [review] [review]:

Did you actually hit this?

See also https://bugzilla.gnome.org/show_bug.cgi?id=687098
It might be worth breaking that out into more reusable code mapping guint -> object.

Your implementation here has quite a major performance cliff.
Comment 3 Dan Winship 2015-08-25 13:47:39 UTC 
FTR, no, NM didn't actually hit this, I think it was just a drive-by fix on Thomas's part.

If we were going to do this, maybe we should have some abstraction of the code used for source ids in gmain
Comment 4 Philip Withnall 2017-10-26 10:39:51 UTC 
Comment on attachment 309959 [details] [review]
handle overflow of filter ids

The surrounding code has changed, so this no longer applies cleanly. It would be good to rework it to not use a `goto`.
Comment 5 GNOME Infrastructure Team 2018-05-24 18:10:05 UTC 
-- GitLab Migration Automatic Message --

This bug has been migrated to GNOME's GitLab instance and has been closed from further activity.

You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.gnome.org/GNOME/glib/issues/1075.