GNOME Bugzilla – Bug 754077
ListView: get rid of the store
Last modified: 2016-09-20 08:15:55 UTC
We should get rid of the GListStore store attribute and simply use the GtkListBox directly: it creates more problems than it solves.
Created attachment 309957 [details] [review] list-view: Unbind view from store Removes the GtkListBox's binding to the store to add and remove the rows manually. This makes the ListView class simpler and gets rid of some workarounds avoiding bugs in the binding.
Created attachment 309958 [details] [review] list-view: Remove store attribute Remove the useless store attribute. This finishes getting rid of workarounds for bugs in the binding between GtkListBox and GListModel and makes the ListView class simpler.
Review of attachment 309957 [details] [review]: I don't see the point of unbinding as a separate change itself. Just drop it in one patch.
Review of attachment 309957 [details] [review]: ::: src/list-view.vala @@ +421,3 @@ App.app.notify_property ("selected-items"); } +} No newline at end of file what's the change here?
Patches squashed and pushed as: commit: d0f19c46d975914d3123fa826c2bba938c36a303 Author: Adrien Plazas <kekun.plazas@laposte.net> list-view: Drop custom model We don't necessarily need a custom model and using a custom model only complicates the code, especially to workaround bug 752615.