After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 754037 - Use upstream gettext
Use upstream gettext
Status: RESOLVED FIXED
Product: gtksourceview
Classification: Platform
Component: General
git master
Other Linux
: Normal enhancement
: ---
Assigned To: GTK Sourceview maintainers
GTK Sourceview maintainers
Depends on:
Blocks:
 
 
Reported: 2015-08-24 18:08 UTC by Javier Jardón (IRC: jjardon)
Modified: 2015-10-11 15:25 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Use upstream gettext (13.20 KB, patch)
2015-08-24 18:08 UTC, Javier Jardón (IRC: jjardon) 		none Details | Review

Description Javier Jardón (IRC: jjardon) 2015-08-24 18:08:58 UTC 
Created attachment 309929 [details] [review]
Use upstream gettext

Instead intltool / glib-gettext
Comment 1 Javier Jardón (IRC: jjardon) 2015-08-24 18:16:39 UTC 
Comment on attachment 309929 [details] [review]
Use upstream gettext

Warning: Not completely tested but distcheck passes
Comment 2 Sébastien Wilmet 2015-08-24 18:23:26 UTC 
Oh, this is unfortunate, I've already created a branch to do the same:
https://git.gnome.org/browse/gtksourceview/log/?h=wip/exterminate-intltool

But it was not really ready to get merged, it still needs more tests. I've tried to not add the generated .pot files to git (generated from itstool).
Comment 3 Sébastien Wilmet 2015-10-03 13:50:46 UTC 
The branch is now finished:
https://git.gnome.org/browse/gtksourceview/log/?h=wip/dont-use-intltool-2

The sub *.pot files that ITS Tool generates must be added to Git, unfortunately. See:
https://mail.gnome.org/archives/desktop-devel-list/2015-October/msg00001.html

We can maybe add a new make target to update all sub *.pot files. And maybe run that target on make check or something, so at least before each release we update the sub *.pot files.

Also, it seems that upstream gettext doesn't check if there are missing files in POTFILES.in. And since it's something we often forget to do…
Comment 4 Sébastien Wilmet 2015-10-11 15:25:10 UTC 
The branch has landed on master.