GNOME Bugzilla – Bug 753934
Files are not marked as untrashable
Last modified: 2015-09-23 08:20:21 UTC
Nautilus offers "Move to Trash" instead of "Delete Permanently" because G_FILE_ATTRIBUTE_ACCESS_CAN_TRASH is not being set to TRUE.
Created attachment 309822 [details] [review] dav: Mark files as untrashable
Review of attachment 309822 [details] [review]: Looks good!
Comment on attachment 309822 [details] [review] dav: Mark files as untrashable Pushed to gnome-3-16 and master.
Reopening because: 1/ "Move to Trash" is no more offered, but I don't see neither "Delete permanently" (nautilus-3.16.2-2.fc22.x86_64), so it is impossible to delete the files at all currently... Is somewhere corresponding Nautilus bug? 2/ It seems the following backends need to be fixed also: daemon/gvfsbackendafc.c daemon/gvfsbackendafp.c daemon/gvfsbackendftp.c daemon/gvfsbackendsftp.c daemon/gvfsbackendsmb.c I can fix the second issue, but I would like to know, what's wrong with the first issue before...
(In reply to Ondrej Holy from comment #4) > Reopening because: > > 1/ "Move to Trash" is no more offered, but I don't see neither "Delete > permanently" (nautilus-3.16.2-2.fc22.x86_64), so it is impossible to delete > the files at all currently... Oops. I was testing primarily with nautilus git master. I will double check with nautilus-3.16.x.
You are right, it works correctly with Nautilus master for me, so the Nautilus feature has to be backported, or the GVfs patch has to be reverted for gnome-3-16 branch...
(In reply to Ondrej Holy from comment #6) > You are right, it works correctly with Nautilus master for me, so the > Nautilus feature has to be backported, or the GVfs patch has to be reverted > for gnome-3-16 branch... I've forgotten that there are already backends with _CAN_TRASH set to FALSE, so we have to fix this in Nautilus... nautilus-3.14.x works correctly for me, so this is bug in nautilus-3.16.x.
(In reply to Ondrej Holy from comment #7) > (In reply to Ondrej Holy from comment #6) > > You are right, it works correctly with Nautilus master for me, so the > > Nautilus feature has to be backported, or the GVfs patch has to be reverted > > for gnome-3-16 branch... > > I've forgotten that there are already backends with _CAN_TRASH set to FALSE, > so we have to fix this in Nautilus... > > nautilus-3.14.x works correctly for me, so this is bug in nautilus-3.16.x. Ok. So let's fix nautilus then. I will file a nautilus bug and try to write a patch for it.
Thanks, I will prepare patches for other backends...
Created attachment 310047 [details] [review] Mark files as untrashable for main backends Mark files as untrashable for backends listed in Comment 4. I've tested the change in ftp, sftp and smb backend. Still a few backends is missing (e.g. smb-browse, afp-browse), but not sure it is necessary here...
Review of attachment 310047 [details] [review]: Looks good.
Thanks for the review, pushed as commit 1a4e823 .