After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 753905 - android emulator returns NULL for GL_SHADING_LANGUAGE_VERSION
android emulator returns NULL for GL_SHADING_LANGUAGE_VERSION
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-bad
git master
Other All
: Normal normal
: 1.5.91
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2015-08-21 05:17 UTC by Justin Kim
Modified: 2015-08-28 18:27 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
separated error message (1.57 KB, patch)
2015-08-21 05:18 UTC, Justin Kim 		none Details | Review
No GL shader support available (1.55 KB, patch)
2015-08-21 07:46 UTC, Justin Kim 		committed Details | Review

Description Justin Kim 2015-08-21 05:17:40 UTC 
In android emulator, it just returns null for GL_SHADING_LANGUAGE_VERSION even if ES returns more than 2.0. For android newbie like me, the error message, "glGetString not defined or returned invalid value", is not sufficient to check what's going on.

I think it's better to provide separated information.
Comment 1 Justin Kim 2015-08-21 05:18:35 UTC 
Created attachment 309785 [details] [review]
separated error message
Comment 2 Sebastian Dröge (slomo) 2015-08-21 07:24:43 UTC 
Review of attachment 309785 [details] [review]:

::: gst-libs/gst/gl/gstglcontext.c
@@ +1127,3 @@
+  if (!gl->GetString (GL_SHADING_LANGUAGE_VERSION)) {
+    g_set_error (error, GST_GL_CONTEXT_ERROR, GST_GL_CONTEXT_ERROR_FAILED,
+        "GL_SHADING_LANGUAGE_VERSION must not be null");

Maybe make this "No GL shader support available" or something like that?
Comment 3 Justin Kim 2015-08-21 07:46:09 UTC 
Created attachment 309791 [details] [review]
No GL shader support available

Yes, your text is more understandable.
Comment 4 Matthew Waters (ystreet00) 2015-08-21 08:17:36 UTC 
Thanks!

commit 85834d6bbc79fe7b88dbff388746b2ff80b1ad75
Author: Justin Kim <justin.kim@collabora.com>
Date:   Fri Aug 21 14:07:32 2015 +0900

    glcontext: add specific error message when missing GL_SHADING_LANGUAGE_VERSION
    
    GL_SHADING_LANGUAGE_VERSION was introduced since ES 2.0, but in some
    android emulator doesn't support this feature. To prevent confusion for
    developer, the error message need to be more clear.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=753905