After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 753900 - state of bookmarks is not unset when the bookmark is removed
state of bookmarks is not unset when the bookmark is removed
Status: RESOLVED FIXED
Product: gedit-plugins
Classification: Other
Component: General
3.14.x
Other Linux
: Normal normal
: ---
Assigned To: Gedit maintainers
Gedit maintainers
Depends on:
Blocks:
 
 
Reported: 2015-08-20 23:46 UTC by Matěj Cepl
Modified: 2019-03-23 20:54 UTC
See Also:
GNOME target: ---
GNOME version: ---



Description Matěj Cepl 2015-08-20 23:46:01 UTC
1. Open a file in gedit with a bookmark (set via bookmarks plugin from the gedit-plugins).

2. Ctrl-B and Ctrl-Alt-B (jump to the bookmark and flip it off)

3. Change file and save

4. Reopen the file

Expected: no bookmark is present

Observed: the old bookmark is still at the place

When looking at the metadata with

    gvfs-info filename|grep metadata::gedit-bookmarks:

I can still see that the bookmark is saved in metadata::gedit
Comment 1 Sébastien Wilmet 2015-08-21 09:12:46 UTC
It should already be fixed in 3.14.4:
https://git.gnome.org/browse/gedit/commit/?h=gnome-3-14&id=c1f59ef858a2b6b14f4c05f49cb8d5b4a1642451

Which 3.14.x version do you use?
Comment 2 Sébastien Wilmet 2015-08-21 09:15:20 UTC
It's anyway fixed on git master, maybe other commits need to be backported.
Comment 3 Matěj Cepl 2015-08-21 12:12:18 UTC
Most likely ... 3.14.3 (which is what we'll have most likely in RHEL 7.2).
Comment 4 Sébastien Wilmet 2015-08-21 12:26:24 UTC
There are important bug fixes between 3.14.3 and 3.14.4:
- a fix for the desktop actions (from gnome-shell, right click on gedit -> open new window, open new document, etc).
- fix file printing (the margins were too small so the text was truncated on the right)
- fixes for document metadata (i.e. this bug, and other annoying bugs with the spell checking).
Comment 5 Matěj Cepl 2015-08-21 13:49:30 UTC
It is slightly off-topic but when I tried to upgrade to 3.14.4, I got this FTBFS:

checking for PYTHON... yes
checking for GEDIT... yes
checking for X11... yes
checking for UNIX... yes
./configure: line 16921: syntax error near unexpected token `tagged-entry'
./configure: line 16921: `LIBGD_INIT(tagged-entry static)'
make: *** [config.status] Error 2
error: Bad exit status from /var/tmp/rpm-tmp.zgWJFN (%build)


RPM build errors:
    Bad exit status from /var/tmp/rpm-tmp.zgWJFN (%build)
Could not execute local: Non zero exit
matej@mitmanek: gedit (rhel-7.2 *%)$ 

(full build log is http://mcepl.fedorapeople.org/tmp/_build-3.14.4-0.0.1.MC.el7.log)

Any ideas, what's wrong?

The only changes to autofoo stuff are these:

matej@mitmanek: gedit (rhel-7.2 *%)$ filterdiff -i '*/configure.ac' gedit-disable-python3.patch 
--- a/configure.ac
+++ b/configure.ac
@@ -303,7 +303,7 @@ if test "x$enable_python" = "xauto"; the
 fi
 
 if test "x$enable_python" = "xyes"; then
-	AM_PATH_PYTHON(3.2.3)
+	AM_PATH_PYTHON
 	PKG_CHECK_MODULES(PYTHON, [pygobject-3.0 >= $PYGOBJECT_REQUIRED])
 
 	pyoverridesdir="\$(pyexecdir)/gi/overrides"
matej@mitmanek: gedit (rhel-7.2 *%)$ cat gedit-2.13.90-libdir.patch 
--- gedit-2.13.90/configure.ac.libdir	2006-02-06 10:06:16.000000000 -0500
+++ gedit-2.13.90/configure.ac	2006-02-06 10:06:26.000000000 -0500
@@ -148,9 +148,9 @@
 	PY_PREFIX=`$PYTHON -c 'import sys ; print sys.prefix'`
 	PY_EXEC_PREFIX=`$PYTHON -c 'import sys ; print sys.exec_prefix'`
 	PYTHON_LIBS="-lpython$PYTHON_VERSION"
-	PYTHON_LIB_LOC="-L$PY_EXEC_PREFIX/lib/python$PYTHON_VERSION/config"
+	PYTHON_LIB_LOC="-L$PY_EXEC_PREFIX/lib64/python$PYTHON_VERSION/config"
 	PYTHON_CFLAGS="-I$PY_PREFIX/include/python$PYTHON_VERSION"
-	PYTHON_MAKEFILE="$PY_EXEC_PREFIX/lib/python$PYTHON_VERSION/config/Makefile"
+	PYTHON_MAKEFILE="$PY_EXEC_PREFIX/lib64/python$PYTHON_VERSION/config/Makefile"
 	PYTHON_LOCALMODLIBS=`sed -n -e 's/^LOCALMODLIBS=\(.*\)/\1/p' $PYTHON_MAKEFILE`
 	PYTHON_BASEMODLIBS=`sed -n -e 's/^BASEMODLIBS=\(.*\)/\1/p' $PYTHON_MAKEFILE`
 	PYTHON_OTHER_LIBS=`sed -n -e 's/^LIBS=\(.*\)/\1/p' $PYTHON_MAKEFILE`
matej@mitmanek: gedit (rhel-7.2 *%)$
Comment 6 Sébastien Wilmet 2015-08-21 14:53:00 UTC
No idea, a package of gedit 3.14.4 is available for Fedora 21, and the libgd git submodule didn't change between 3.14.3 and 3.14.4.

I think we can close the bug, since it is fixed upstream.