GNOME Bugzilla – Bug 753888
A machine being saved shouldn't be tagged as paused
Last modified: 2016-09-20 08:15:55 UTC
Created attachment 309751 [details] The first item of the list displays "Saving... paused" When a machine is being saved, it appears in the "paused" state which looks weird in the list view. Should we add MachineState.SAVING?
Just wanted to let you know that I'm working on this.
Thanks for warning me, you'll probably know how to deal with it way better than me.
commit: 61cc6b3f6a0210c240035e9e388813b633c1fe6f Revert "machine: Ensure 'status' property is always set" This reverts commit 63b978a880f8e72d8353a5b5c50223bbf09a489e. This retioanale for the reverted commit was the fact that 'status' property is (indirectly) bound 'accessible-name' property of AppWindow and that is non-nullable so we end-up with a warning on console. This issue will be solved in a following patch in a different way but we can't have Machine.name being permanently mapped to it's 'status' anymore as we are about to expand the role of 'status' property and show it's contents also in collection view. commit: bfcaeb72e7237523408d190f1c81fb85d06574c0 app-window: Don't bind a11-name to topbar.status Permanently binding 'accessible-name' property to topbar.status could easily lead to null be set on this non-nullable property and that leads to warnings on the console from gtk+. We only need machine's name set as 'accessible-name' when machine in question is in the foreground, so no need for this binding anyway. commit: aa99385fc5866cf539beb5491dc28f69de102d60 topbar: 'status' property now nullable commit: 660188baf1ae0a07323eb0b162be7bbd2359ec5e machine: Only bind 'status' to 'name' in DISPLAY state commit: 7074809940120f3ea618ef365357554cf4443a55 machine: Ensure 'saving' flag is reset on failure Ensure that 'reset' boolean field is reset if saving operation fails. commit: a131e950361156e52ce7967fc2ea813dca8a03f7 machine: Status in 'status' prop, not 'info' Since 'info' property is bound to 2nd text line under the box thumbnail, we have been (ab)using this property to keep status messages too. We already have a 'status' property for those and that is where these messages should go into. With this patch, these status messages will no longer appear under the box thumbnail but this is a temporary regression that will be fixed in a following patch. commit: 2ff84ead04a225d7eee9706916d5a748db7afeef collection-view: Refactor Machine.info notify handler Put code handling changes to Machine.info property, into a separate function. In a following patch, we'll be launching the same function for Machine.status change as well. commit: 495762d01c0ca89b19e0c4bd44f7fabffa67e39a collection-view: Show Machine.status when available If Machine.status is non-null, show that in the second column of text instead of Machine.info since former is now more important than latter. commit: 7cf3a739c517fc10364d5316e731811082d2b861 list-view-row: state_label -> status_label We are about to extend the role of state_label to also show Machine.status so better give it and associated update_state() a more generic name. commit: 4ba9352ac7db92d584c1409eabd6e7fa3922be13 list-view-row: Don't disable status_label for styling Instead of disabling the status_label, add/remove style classes to it. commit: 99dc000f7e3d04a80aac3a905d3251538504ef4b list-view-row: Show Machine.status when available If Machine.status is non-null, show that in the status label instead of machine's state since former is now more important than latter.