After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 753828 - region: If language isn't set in AccountsService, show current locale
region: If language isn't set in AccountsService, show current locale
Status: RESOLVED FIXED
Product: gnome-control-center
Classification: Core
Component: Region & Language
unspecified
Other All
: Normal normal
: ---
Assigned To: Control-Center Maintainers
Control-Center Maintainers
Depends on:
Blocks:
 
 
Reported: 2015-08-19 13:58 UTC by Rui Matos
Modified: 2015-08-25 11:18 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
region: If language isn't set in AccountsService, show current locale (1.20 KB, patch)
2015-08-19 13:58 UTC, Rui Matos 		committed Details | Review

Description Rui Matos 2015-08-19 13:58:50 UTC 
Downstream report: https://bugzilla.redhat.com/show_bug.cgi?id=1148382
Comment 1 Rui Matos 2015-08-19 13:58:55 UTC 
Created attachment 309601 [details] [review]
region: If language isn't set in AccountsService, show current locale

For newly created user accounts, AccountsService won't have the
language property set. Instead of defaulting to en_US in that case,
let's fallback to the current locale.
Comment 2 Bastien Nocera 2015-08-25 09:57:11 UTC 
Review of attachment 309601 [details] [review]:

Looks good otherwise.

::: panels/region/cc-region-panel.c
@@ +630,3 @@
                 language = act_user_get_language (priv->user);
+
+        if (language == NULL || language[0] == '\0')

I prefer *language == '\0'
Comment 3 Rui Matos 2015-08-25 11:18:21 UTC 
Attachment 309601 [details] pushed as 4a91056 - region: If language isn't set in AccountsService, show current locale