After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 753821 - assrender: improve overlay blending performance
assrender: improve overlay blending performance
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-bad
git master
Other Linux
: Normal enhancement
: 1.7.1
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2015-08-19 12:53 UTC by Arnaud Vrac
Modified: 2015-10-02 14:24 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
optimize blending (2.43 KB, patch)
2015-08-19 12:53 UTC, Arnaud Vrac 		committed Details | Review

Description Arnaud Vrac 2015-08-19 12:53:08 UTC 
Created attachment 309575 [details] [review]
optimize blending

Skip empty source pixels when blending an image. There can be hundreds          
of images to blend at each frame, so this brings a nice performance
boost.
Comment 1 Nicolas Dufresne (ndufresne) 2015-08-19 21:22:03 UTC 
Review of attachment 309575 [details] [review]:

I wonder why we don't focus on moving toward the blending API we have in the CompositionOverlay code ?
Comment 2 Arnaud Vrac 2015-08-19 21:40:31 UTC 
Blending of libass images is special since you need to blend many 1bpp images, each having a different ARGB color. It might be possible to optimise the code but I'm not sure the generic composition blending code could help here.
Comment 3 Nicolas Dufresne (ndufresne) 2015-08-19 21:43:00 UTC 
Thanks, I simply didn't know.
Comment 4 Sebastian Dröge (slomo) 2015-10-02 14:24:19 UTC 
commit 3b1e0951696298ae373b0a5b1e8216f0e992be7d
Author: Arnaud Vrac <avrac@freebox.fr>
Date:   Thu Jun 25 19:17:36 2015 +0200

    assrender: optimize blending
    
    Skip empty source pixels when blending an image. There can be hundreds
    of images to blend at each frame, so this brings a nice performance
    boost.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=753821