After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 753820 - video-bad: fix build failure
video-bad: fix build failure
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-bad
git master
Other Linux
: Normal normal
: 1.5.91
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2015-08-19 12:40 UTC by Arnaud Vrac
Modified: 2015-08-28 18:27 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
configure.ac: always check gst-video from base is available (1.26 KB, patch)
2015-08-19 12:40 UTC, Arnaud Vrac
none Details | Review
fix build when the uvch264 plugin is not selected (3.50 KB, patch)
2015-08-19 13:41 UTC, Arnaud Vrac
committed Details | Review

Description Arnaud Vrac 2015-08-19 12:40:36 UTC
Created attachment 309572 [details] [review]
configure.ac: always check gst-video from base is available

GST_VIDEO Makefile variables won't be defined if the uvch264 plugin is not built, since in this case we don't check that the gstreamer-video-1.0 package is installed.
Comment 1 Sebastian Dröge (slomo) 2015-08-19 12:47:59 UTC
Comment on attachment 309572 [details] [review]
configure.ac: always check gst-video from base is available

Usually what we do is to use $(GST_PLUGINS_BASE_LIBS) -lgstvideo-$(GST_API_VERSION) and $(GST_PLUGINS_BASE_CFLAGS). Want to update that?
Comment 2 Arnaud Vrac 2015-08-19 13:41:05 UTC
Created attachment 309599 [details] [review]
fix build when the uvch264 plugin is not selected

Here you go. In sys/uvch264/Makefile.am the $(GST_PLUGINS_BASE_LIBS) was used twice, I'm not sure if this was a typo or not. I've removed the duplicate entry.
Comment 3 Sebastian Dröge (slomo) 2015-08-19 13:52:22 UTC
commit 697f117ddda44d0386e46e082dbd6190d837db2a
Author: Arnaud Vrac <avrac@freebox.fr>
Date:   Wed Aug 19 15:31:16 2015 +0200

    configure.ac: fix build when the uvch264 plugin is not selected
    
    Instead of checking for the gstreamer-video-1.0 package is installed,
    just assume it is since we already check for the -base dependency.
    
    With this replace the GST_VIDEO_* variables in makefiles and directly
    link with libgstvideo.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=753820