After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 753782 - Splitting a clip does not seem to apply effects correctly
Splitting a clip does not seem to apply effects correctly
Status: RESOLVED NOTABUG
Product: GStreamer
Classification: Platform
Component: gst-editing-services
1.4.0
Other Mac OS
: Normal normal
: git master
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2015-08-19 00:22 UTC by Sjors Gielen
Modified: 2015-09-12 13:19 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Test case. See description for instructions. (2.18 KB, text/x-c)
2015-08-19 00:22 UTC, Sjors Gielen
Details

Description Sjors Gielen 2015-08-19 00:22:36 UTC
Created attachment 309516 [details]
Test case. See description for instructions.

When applying effects to a clip, then splitting it in two halves, the effects seem not to be applied correctly to the second half. In particular, the effects may be applied to a different clip instead. A test case is attached that shows the problem.

The test case can be compiled using:
  cc `pkg-config gst-editing-services-1.0 --cflags` `pkg-config gst-editing-services-1.0 --libs` -Wall main.c -o main

Expected behavior: cliphigh should be audible for 4 seconds, because it has no effects applied. cliplow should be inaudible for 4 seconds, because it is muted in both halves. (This is the observed behavior without the split.)

Behavior observed: cliphigh is audible for 2 seconds, while cliplow is inaudible. However, at the point of the split, cliplow becomes audible, while cliphigh becomes inaudible.

It is possible that ges_clip_split applies the effects to cliphigh instead of the second half of cliplow by accident. Note that this effect is not observed when cliphigh is split instead of cliplow.
Comment 1 Sjors Gielen 2015-08-19 00:46:37 UTC
This seems fixed in GES master, however. I'll leave this open until I've (or someone else has) figured out in what release it was fixed.
Comment 2 Sjors Gielen 2015-08-19 00:57:45 UTC
Even though this test case now succeeds, I'm still having similar problems and I suspect it might be the same bug; I'll try to re-work it into a test case and attach it again here.
Comment 3 Sjors Gielen 2015-09-12 13:19:10 UTC
For future reference: this bug was caused by the fact that layers did not have their priorities set correctly in the test case.

To prevent that, never use ges_layer_new()+ges_timeline_add_layer(), as it creates layers with overlapping priorities; instead, always use ges_timeline_append_layer(), which returns a new layer already added to the timeline with a unique priority.