After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 753781 - tags: Add support for ImageNumber / ImageID EXIF tags
tags: Add support for ImageNumber / ImageID EXIF tags
Status: RESOLVED OBSOLETE
Product: GStreamer
Classification: Platform
Component: gst-plugins-base
git master
Other Linux
: Normal enhancement
: git master
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2015-08-18 22:54 UTC by minfrin
Modified: 2018-11-03 11:40 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Patch for gstreamer (1.75 KB, patch)
2015-08-18 22:54 UTC, minfrin 		none Details | Review
Patch for gst-plugins-base (1.55 KB, patch)
2015-08-18 22:55 UTC, minfrin 		none Details | Review
Updated patch with comment fixed (2.14 KB, patch)
2015-08-20 10:35 UTC, minfrin 		none Details | Review
Patch for gst-plugin-base (1.91 KB, patch)
2015-08-20 10:43 UTC, minfrin 		none Details | Review
Patch for gstreamer (2.19 KB, patch)
2016-09-09 20:58 UTC, minfrin 		none Details | Review
Patch for gst-plugin-base (1.96 KB, patch)
2016-09-09 21:01 UTC, minfrin 		none Details | Review

Description minfrin 2015-08-18 22:54:04 UTC 
The following patch adds support for ImageNumber / ImageID tags:

#define EXIF_TAG_IMAGE_ID 0x800d
#define EXIF_TAG_IMAGE_NUMBER 0x9211
Comment 1 minfrin 2015-08-18 22:54:45 UTC 
Created attachment 309509 [details] [review]
Patch for gstreamer
Comment 2 minfrin 2015-08-18 22:55:25 UTC 
Created attachment 309510 [details] [review]
Patch for gst-plugins-base
Comment 3 Sebastian Dröge (slomo) 2015-08-19 07:22:19 UTC 
I think the tags themselves should be in libgsttag in gst-plugins-base, and maybe prefixed with EXIF?
Comment 4 Sebastian Dröge (slomo) 2015-08-19 07:23:30 UTC 
Review of attachment 309509 [details] [review]:

See comments above also

::: gst/gsttaglist.h
@@ +652,3 @@
+ * Number assigned to an image, e.g., in a chained image burst. (long)
+ */
+#define GST_TAG_IMAGE_NUMBER           "image-number"

You register the tag with UINT, and define it here as long. Which one should it be? :)

long is generally a bad idea, make it either uint or uint64
Comment 5 Sebastian Dröge (slomo) 2015-08-19 07:24:01 UTC 
Review of attachment 309510 [details] [review]:

Looks good except for the other patch, thanks :)
Comment 6 Sebastian Dröge (slomo) 2015-08-19 07:27:07 UTC 
Also please provide all patches in "git format-patch" format with descriptive commit messages
Comment 7 minfrin 2015-08-19 09:26:13 UTC 
I wasn't sure where the tags were supposed to go. Some of them are defined in gst/gsttaglist.h while others are defined in gst-libs/gst/tag/tag.h - can you confirm which one is preferred?

The "(long)" needs to be removed, this refers to an EXIF long, which is a G_TYPE_UINT32.
Comment 8 minfrin 2015-08-20 10:35:04 UTC 
Created attachment 309690 [details] [review]
Updated patch with comment fixed

Patch updated with fixed comment as requested.
Comment 9 minfrin 2015-08-20 10:43:48 UTC 
Created attachment 309692 [details] [review]
Patch for gst-plugin-base

Patch with format-patch for gst-plugins-base.
Comment 10 minfrin 2016-09-09 20:58:34 UTC 
Created attachment 335213 [details] [review]
Patch for gstreamer
Comment 11 minfrin 2016-09-09 21:01:44 UTC 
Created attachment 335214 [details] [review]
Patch for gst-plugin-base
Comment 12 minfrin 2017-04-21 20:43:49 UTC 
Quick ping, any news?
Comment 13 GStreamer system administrator 2018-11-03 11:40:37 UTC 
-- GitLab Migration Automatic Message --

This bug has been migrated to freedesktop.org's GitLab instance and has been closed from further activity.

You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.freedesktop.org/gstreamer/gst-plugins-base/issues/215.