After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 753777 - Implement a view for Other Locations
Implement a view for Other Locations
Status: RESOLVED FIXED
Product: nautilus
Classification: Core
Component: Views: All
unspecified
Other All
: Normal normal
: ---
Assigned To: Georges Basile Stavracas Neto
Nautilus Maintainers
Depends on:
Blocks:
 
 
Reported: 2015-08-18 21:34 UTC by Georges Basile Stavracas Neto
Modified: 2015-08-21 02:47 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
places-view: implement a view for Other Locations (140.95 KB, patch)
2015-08-18 21:34 UTC, Georges Basile Stavracas Neto 		none Details | Review
bundle patch for master (238.37 KB, patch)
2015-08-18 22:38 UTC, Georges Basile Stavracas Neto 		none Details | Review
view: add interface (63.06 KB, patch)
2015-08-19 10:34 UTC, Georges Basile Stavracas Neto 		none Details | Review
places-view: implement a view for Other Locations (152.04 KB, patch)
2015-08-19 10:36 UTC, Georges Basile Stavracas Neto 		none Details | Review
view: add interface (67.28 KB, patch)
2015-08-19 19:23 UTC, Georges Basile Stavracas Neto 		none Details | Review
places-view: implement a view for Other Locations (152.34 KB, patch)
2015-08-19 19:24 UTC, Georges Basile Stavracas Neto 		none Details | Review
places-view: implement a view for Other Locations (152.34 KB, patch)
2015-08-19 20:55 UTC, Georges Basile Stavracas Neto 		none Details | Review

Description Georges Basile Stavracas Neto 2015-08-18 21:34:14 UTC 
GtkFileChooser received a Other Locations view that lists
persistent devices, as well as networks and the root location
for the computer's hard drive.

Since Nautilus is a file management tool too, it should keep
consistency between Gtk+ file chooser, something that doesn't
happen since it doesn't display Other Locations.

To fix that, add NautilusPlacesView, a NautilusView implementation
that displays the GtkPlacesView widget. In order to implement that,
update window-slot to correctly display the places-view whenever
Other Locations is clicked.
Comment 1 Georges Basile Stavracas Neto 2015-08-18 21:34:30 UTC 
Created attachment 309504 [details] [review]
places-view: implement a view for Other Locations
Comment 2 Georges Basile Stavracas Neto 2015-08-18 22:38:19 UTC 
Created attachment 309508 [details] [review]
bundle patch for master

This is a bundle that applies on top of master.
Comment 3 Georges Basile Stavracas Neto 2015-08-19 10:34:40 UTC 
Created attachment 309541 [details] [review]
view: add interface

This patch adds the NautilusView interface and makes NautilusFilesView a NautilusView implementation. In order to achieve that, the search logic had to be refactored.
Comment 4 Georges Basile Stavracas Neto 2015-08-19 10:36:48 UTC 
Created attachment 309542 [details] [review]
places-view: implement a view for Other Locations

Adds NautilusPlacesView, a NautilusView implementation that displays the Other Locations content. NautilusWindowSlot's view loading code was refactored in order to achieve that.
Comment 5 Georges Basile Stavracas Neto 2015-08-19 19:23:31 UTC 
Created attachment 309633 [details] [review]
view: add interface

Improve code quality.
Comment 6 Georges Basile Stavracas Neto 2015-08-19 19:24:22 UTC 
Created attachment 309637 [details] [review]
places-view: implement a view for Other Locations

Update Gtk+ widget. It is actually more updated than the upstream version.
Comment 7 Georges Basile Stavracas Neto 2015-08-19 20:55:12 UTC 
Created attachment 309643 [details] [review]
places-view: implement a view for Other Locations

Update patch.
Comment 8 Georges Basile Stavracas Neto 2015-08-21 02:47:12 UTC 
Fixed on master.