After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 753773 - exif: write_exif_integer_tag_from_taglist: Silently ignores unsigned int values
exif: write_exif_integer_tag_from_taglist: Silently ignores unsigned int values
Status: RESOLVED OBSOLETE
Product: GStreamer
Classification: Platform
Component: gst-plugins-base
git master
Other Linux
: Normal normal
: git master
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2015-08-18 18:47 UTC by minfrin
Modified: 2018-11-03 11:40 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Patch to fix the problem (615 bytes, patch)
2015-08-18 18:47 UTC, minfrin 		none Details | Review
0001-Allow-values-of-type-G_TYPE_UINT-to-be-written-to-EX.patch (997 bytes, patch)
2015-08-21 11:50 UTC, minfrin 		none Details | Review
Allow values of type G_TYPE_UINT to be written to EXIF_SHORT and EXIF_LONG. (1.11 KB, patch)
2016-09-09 22:54 UTC, minfrin 		none Details | Review

Description minfrin 2015-08-18 18:47:27 UTC 
Created attachment 309502 [details] [review]
Patch to fix the problem

The write_exif_integer_tag_from_taglist() function will only write the value if the GValue is a signed integer, unsigned integers are not supported (even though both EXIF short and long are unsigned).

Patch attached to fix this.
Comment 1 Sebastian Dröge (slomo) 2015-08-19 07:31:06 UTC 
Comment on attachment 309502 [details] [review]
Patch to fix the problem

Please provide this in "git format-patch" format with a descriptive commit message.


Otherwise it looks good to me. I assume EXIF_LONG is defined as a 32 bit integer? Otherwise you might also want to handle the 64 bit integer types here.
Comment 2 minfrin 2015-08-19 09:03:21 UTC 
Will try that again tonight.

EXIF_LONG is indeed 32 bits.
Comment 3 minfrin 2015-08-21 11:50:31 UTC 
Created attachment 309808 [details] [review]
0001-Allow-values-of-type-G_TYPE_UINT-to-be-written-to-EX.patch

Same patch, this time with format-patch.
Comment 4 minfrin 2016-09-09 22:54:46 UTC 
Created attachment 335217 [details] [review]
Allow values of type G_TYPE_UINT to be written to EXIF_SHORT and EXIF_LONG.

Fix a conflict, reapply the patch to git master.
Comment 5 minfrin 2017-04-21 20:58:53 UTC 
Quick ping, any news?
Comment 6 GStreamer system administrator 2018-11-03 11:40:15 UTC 
-- GitLab Migration Automatic Message --

This bug has been migrated to freedesktop.org's GitLab instance and has been closed from further activity.

You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.freedesktop.org/gstreamer/gst-plugins-base/issues/213.