After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 753766 - Scaling of RDP sessions
Scaling of RDP sessions
Status: RESOLVED FIXED
Product: vinagre
Classification: Applications
Component: RDP
unspecified
Other Linux
: Normal enhancement
: ---
Assigned To: vinagre-maint
vinagre-maint
Depends on:
Blocks:
 
 
Reported: 2015-08-18 15:12 UTC by Marek Kašík
Modified: 2015-09-04 14:36 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Allow scaling of RDP sessions (24.22 KB, patch)
2015-08-18 15:12 UTC, Marek Kašík
needs-work Details | Review
Allow scaling of RDP sessions (24.07 KB, patch)
2015-09-04 14:29 UTC, Marek Kašík
committed Details | Review

Description Marek Kašík 2015-08-18 15:12:53 UTC
Created attachment 309481 [details] [review]
Allow scaling of RDP sessions

It would be nice to have ability to scale RDP session as we have in other plugins.
The attached patch adds this ability. It also moves the session to the center of the window.
Comment 1 David King 2015-08-25 13:50:27 UTC
Review of attachment 309481 [details] [review]:

Looks good in general, just a minor nitpick. If this does not add any new strings (which seems to be the case, as the translatable strings look like they already exist in Vinagre), it can probably go on master.

::: plugins/rdp/vinagre-rdp-connection.c
@@ +45,3 @@
   conn->priv = G_TYPE_INSTANCE_GET_PRIVATE (conn, VINAGRE_TYPE_RDP_CONNECTION, VinagreRdpConnectionPrivate);
+
+  conn->priv->scaling = FALSE;

This will not quite give you the result that you expect. As scaling is a construct property, the default (FALSE) would already be set in constructed(), overriding any value set in init(). As FALSE is the default anyway, it's probably better to not set it in init().
Comment 2 Marek Kašík 2015-09-04 14:29:10 UTC
Created attachment 310671 [details] [review]
Allow scaling of RDP sessions

Thank you for the review. I've removed the initialization of priv->scaling in VinagreRdpConnection. I've also tested translation of the translatable strings by running vinagre with LC_ALL="cs_CZ" and they were all translated.
Comment 3 David King 2015-09-04 14:35:33 UTC
Review of attachment 310671 [details] [review]:

Thanks! Pushed to master as commit 66f91ed8a5c07d17f44990a8f5fb7647df04f60d.