GNOME Bugzilla – Bug 753766
Scaling of RDP sessions
Last modified: 2015-09-04 14:36:06 UTC
Created attachment 309481 [details] [review] Allow scaling of RDP sessions It would be nice to have ability to scale RDP session as we have in other plugins. The attached patch adds this ability. It also moves the session to the center of the window.
Review of attachment 309481 [details] [review]: Looks good in general, just a minor nitpick. If this does not add any new strings (which seems to be the case, as the translatable strings look like they already exist in Vinagre), it can probably go on master. ::: plugins/rdp/vinagre-rdp-connection.c @@ +45,3 @@ conn->priv = G_TYPE_INSTANCE_GET_PRIVATE (conn, VINAGRE_TYPE_RDP_CONNECTION, VinagreRdpConnectionPrivate); + + conn->priv->scaling = FALSE; This will not quite give you the result that you expect. As scaling is a construct property, the default (FALSE) would already be set in constructed(), overriding any value set in init(). As FALSE is the default anyway, it's probably better to not set it in init().
Created attachment 310671 [details] [review] Allow scaling of RDP sessions Thank you for the review. I've removed the initialization of priv->scaling in VinagreRdpConnection. I've also tested translation of the translatable strings by running vinagre with LC_ALL="cs_CZ" and they were all translated.
Review of attachment 310671 [details] [review]: Thanks! Pushed to master as commit 66f91ed8a5c07d17f44990a8f5fb7647df04f60d.