After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 753732 - tracker: track number is missing from grilo information
tracker: track number is missing from grilo information
Status: RESOLVED FIXED
Product: grilo
Classification: Other
Component: plugins
unspecified
Other Linux
: Normal normal
: ---
Assigned To: grilo-maint
grilo-maint
Depends on:
Blocks:
 
 
Reported: 2015-08-17 18:43 UTC by Xavier Claessens
Modified: 2015-08-17 18:55 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
tracker: import nmm:trackNumber info (901 bytes, patch)
2015-08-17 18:44 UTC, Xavier Claessens
none Details | Review
tracker: Populate track number metadata (904 bytes, patch)
2015-08-17 18:49 UTC, Xavier Claessens
committed Details | Review

Description Xavier Claessens 2015-08-17 18:43:52 UTC
Tracker has a nmm:trackNumber field that should be imported.
Comment 1 Xavier Claessens 2015-08-17 18:44:13 UTC
Created attachment 309416 [details] [review]
tracker: import nmm:trackNumber info
Comment 2 Bastien Nocera 2015-08-17 18:46:32 UTC
Review of attachment 309416 [details] [review]:

Looks good, except the commit subject.

This should be in the commit message body, and a user-facing (developer-facing in this case) explanation in the subject.
"tracker: Populate track number metadata" for example.
Comment 3 Xavier Claessens 2015-08-17 18:49:53 UTC
Created attachment 309417 [details] [review]
tracker: Populate track number metadata
Comment 4 Bastien Nocera 2015-08-17 18:54:02 UTC
Review of attachment 309417 [details] [review]:

Looks good (and you could have committed directly after fixing the message :)
Comment 5 Xavier Claessens 2015-08-17 18:54:56 UTC
Comment on attachment 309417 [details] [review]
tracker: Populate track number metadata

Thanks.