After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 753726 - [review] properly handle parent interfaces (IFLA_LINK) in other netns (IFLA_LINK_NETNSID) [th/platform-parent-other-netns-bgo753726]
[review] properly handle parent interfaces (IFLA_LINK) in other netns (IFLA_L...
Status: RESOLVED FIXED
Product: NetworkManager
Classification: Platform
Component: general
git master
Other Linux
: Normal normal
: ---
Assigned To: NetworkManager maintainer(s)
NetworkManager maintainer(s)
Depends on:
Blocks: nm-review
 
 
Reported: 2015-08-17 17:04 UTC by Thomas Haller
Modified: 2015-08-25 21:10 UTC
See Also:
GNOME target: ---
GNOME version: ---


Description Thomas Haller 2015-08-17 17:04:47 UTC 
Please review.


Needs kernel support and libnl [1]



[1] https://github.com/thom311/libnl/commit/8818a571e72c51bcda309d89bfaf93a2f5524d68
Comment 1 Thomas Haller 2015-08-17 17:05:46 UTC 
branch: th/platform-parent-other-netns-bgo753726
Comment 2 Thomas Haller 2015-08-25 21:10:44 UTC 
merged as master after ACK from lrintel:

master: http://cgit.freedesktop.org/NetworkManager/NetworkManager/commit/?id=01580195fabbf59c903ffa9ba307820c62164db0

nm-1-0: http://cgit.freedesktop.org/NetworkManager/NetworkManager/commit/?id=e16ebfb4a6c444af00f263ce7805e2decce268d4

I actually didn't make sure that all vlan/macvlan/infiband work properly with a parent in another netns. But note that the code is already buggy in those cases, so this won't break anything that isn't already broken.
(in fact I tried to get it right for those cases -- *fingers crossed*).