GNOME Bugzilla – Bug 753713
Remove "button-*" configuration
Last modified: 2016-04-05 23:35:27 UTC
The button-power, button-suspend, etc. configurations accept a GsdPowerActionType, but not all of the variants are supported: case GSD_POWER_ACTION_BLANK: case GSD_POWER_ACTION_LOGOUT: case GSD_POWER_ACTION_NOTHING: /* these actions cannot be handled by media-keys and * are not used in this context */ break; Given that we usually prefer to avoid this sort of configuration which should work out of the box, it would be better to have act as they are labelled, and people who want to change the configurations at system level can use udev to apply a new keymap.
Created attachment 310374 [details] [review] media-keys: Remove "button-*" configuration The button-power, button-suspend, etc. configurations accept a GsdPowerActionType, but not all of the variants are supported: case GSD_POWER_ACTION_BLANK: case GSD_POWER_ACTION_LOGOUT: case GSD_POWER_ACTION_NOTHING: /* these actions cannot be handled by media-keys and * are not used in this context */ break; Given that we usually prefer to avoid this sort of configuration which should work out of the box, it would be better to have act as they are labelled, and people who want to change the configurations at system level can use udev to apply a new keymap.
Review of attachment 310374 [details] [review]: Looks good. Commit message typo: "it would be better to have *something missing here* act as they are labelled"
With the typo in the commit message fixed. Attachment 310374 [details] pushed as 50564cd - media-keys: Remove "button-*" configuration
this is not really well-thought-out change 1. if buttons should do what they say on a tin why power button does suspend and not poweroff the system? 2. how do i make power button interactive? (as it was possible in 3.16) is there a way to roll back this change?
Bastien Nocera, could you explain how to use udev to apply a new keymap? I want my power button to show dialog instead of immediately suspend. The best it would be revert this "fix". Regards, Ihor
(In reply to optional real name from comment #4) > this is not really well-thought-out change > 1. if buttons should do what they say on a tin why power button does suspend > and not poweroff the system? Fair, but that would just make me change the description of the change, not the change. > 2. how do i make power button interactive? (as it was possible in 3.16) You can't. I don't have any plans on making this possible. > is there a way to roll back this change? You can run "git revert 50564cd" in a git checkout of gnome-settings-daemon, and apply that patch to your version of gnome-settings-daemon.
Bastien, As pointed out here: https://www.reddit.com/r/gnome/comments/3oddse/buttonpower_gone_in_318/ The call: GSettingsComboEnumTweak(_("Power Button Action"), "org.gnome.settings-daemon.plugins.power", "button-power", size_group=sg) is still being made here: https://git.gnome.org/browse/gnome-tweak-tool/tree/gtweak/tweaks/tweak_group_shell.py#n111 I also prefer the interactive dialog. As Ihor asked, could you please give an example of a udev rule that will yield the same interactive dialog and/or poweroff when pressing the power button?
(In reply to Eric from comment #7) > Bastien, > > As pointed out here: > https://www.reddit.com/r/gnome/comments/3oddse/buttonpower_gone_in_318/ I'm not going to increase my blood pressure by reading reddit. > The call: > GSettingsComboEnumTweak(_("Power Button Action"), > "org.gnome.settings-daemon.plugins.power", "button-power", size_group=sg) > > is still being made here: > https://git.gnome.org/browse/gnome-tweak-tool/tree/gtweak/tweaks/ > tweak_group_shell.py#n111 You'll need to file a bug against gnome-tweak-tool. > I also prefer the interactive dialog. As Ihor asked, could you please give > an example of a udev rule that will yield the same interactive dialog and/or > poweroff when pressing the power button? See bug 755953.
(In reply to Eric from comment #7) > I also prefer the interactive dialog. (In reply to optional real name from comment #4) > 2. how do i make power button interactive? (as it was possible in 3.16) In https://bugzilla.gnome.org/show_bug.cgi?id=755953 could you please answer those questions: - Can you explain why you prefer the interactive dialogue? Do you use it to hibernate the machine? Or to suspend it? Or to power it off? If you use it to power off, why not use the power off menu item in the status menu? - Are you using this on laptops or on desktops?
Hi friends! I can somewhat agree with the logic that buttons should do as labeled. However, on most notebooks, power button suspends the computer which usually is not the desired behavior. IMO, we should keep the settings as this option is often customized and opposite doesn't bring any improvements. Kind regards, Momcilo Medic.
(In reply to Momcilo Medic from comment #10) <snip> > IMO, we should keep the settings as this option is often customized and > opposite doesn't bring any improvements. Best read the bugs completely before commenting. Already fixed and released.
I am sorry for the noise then, I didn't follow up in the other bug. Keep up the good work. Kind regards, Momcilo.