After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 753691 - make install -j2 fails when building for MinGW
make install -j2 fails when building for MinGW
Status: RESOLVED FIXED
Product: gtk+
Classification: Platform
Component: .General
2.24.x
Other Linux
: Normal normal
: ---
Assigned To: gtk-bugs
gtk-bugs
Depends on:
Blocks:
 
 
Reported: 2015-08-16 16:54 UTC by Ting-Wei Lan
Modified: 2015-08-20 03:41 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Makefiles: Fix parallel installation for MinGW (2.69 KB, patch)
2015-08-19 03:22 UTC, Ting-Wei Lan 		committed Details | Review

Description Ting-Wei Lan 2015-08-16 16:54:22 UTC 
This problem was reported by an Arch Linux user (Alister.Hood):
https://aur.archlinux.org/packages/mingw-w64-gtk2/

In gdk/Makefile.am, gtk/Makefile.am, modules/other/gail/libgail-util/Makefile.am, install-def-file is used to install .def files to $(DESTDIR)$(libdir). However, install-def-file is listed in install-data-local, not install-exec-hook, so it is possible for install-def-file to be executed before install-exec. This causes install-def-file to fail because $(DESTDIR)$(libdir) does not exist.

I think the same problem can also happen for install-ms-lib although it is not tested. The possible solution may be:

 1. Move them to install-exec-hook.
 2. Run $(mkinstalldirs) before $(INSTALL).
Comment 1 Ting-Wei Lan 2015-08-19 03:22:11 UTC 
Created attachment 309518 [details] [review]
Makefiles: Fix parallel installation for MinGW

Make sure that the destination exists before installing files.
Comment 2 Matthias Clasen 2015-08-19 20:07:58 UTC 
Review of attachment 309518 [details] [review]:

sure, looks fine
Comment 3 Ting-Wei Lan 2015-08-20 03:41:44 UTC 
Attachment 309518 [details] pushed as 46c28bd - Makefiles: Fix parallel installation for MinGW