After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 753637 - proposal: merge FsElementAddedNotifier in gstreamer (as GstElementAddedNotifier?)
proposal: merge FsElementAddedNotifier in gstreamer (as GstElementAddedNotifi...
Status: RESOLVED DUPLICATE of bug 578933
Product: GStreamer
Classification: Platform
Component: gstreamer (core)
git master
Other Linux
: Normal enhancement
: git master
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Reported: 2015-08-14 17:13 UTC by George Kiagiadakis
Modified: 2015-08-15 09:29 UTC
See Also:
GNOME target: ---
GNOME version: ---

base: import GstElementAddedNotifier from farstream (FsElementAddedNotifier) (18.15 KB, patch)
2015-08-14 17:13 UTC, George Kiagiadakis
none Details | Review

Description George Kiagiadakis 2015-08-14 17:13:07 UTC
Created attachment 309297 [details] [review]
base: import GstElementAddedNotifier from farstream (FsElementAddedNotifier)

Farstream includes a class called "FsElementAddedNotifier", which I have found quite useful in various projects that don't use farstream. FsElementAddedNotifier basically extends the functionality of GstChildProxy and emits a signal when an element is added in a bin or any of its child bins, regardless of the parent-child depth level.

In farstream this is used in combination with fsconference in order to set encoder properties in the encoders that get autoplugged inside the conference bin.

Similarly, outside of farstream, I have found this useful in combination with decodebin/uridecodebin, which are also autoplugging elements. Setting the properties of those elements can only be done properly with this class.

I think that merging it in GStreamer would be useful. The question would be how to name it and where to place it. I would propose to just name it "GstElementAddedNotifier" and place it in gstbase. The attached patch implements this proposal.
Comment 1 Sebastian Dröge (slomo) 2015-08-14 17:15:42 UTC
I think this is a duplicate of bug #578933
Comment 2 Tim-Philipp Müller 2015-08-15 09:29:56 UTC
This looks pretty gross (although I realise of course that there are limits to what one can do from the outside) :)

There must be better solutions.

*** This bug has been marked as a duplicate of bug 578933 ***