After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 753627 - Add touchpad gesture event mask to EogScrolledWindow
Add touchpad gesture event mask to EogScrolledWindow
Status: RESOLVED FIXED
Product: eog
Classification: Core
Component: gestures
unspecified
Other Linux
: Normal normal
: ---
Assigned To: Carlos Garnacho
EOG Maintainers
Depends on:
Blocks:
 
 
Reported: 2015-08-14 12:21 UTC by Carlos Garnacho
Modified: 2015-08-17 20:39 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
EogScrollView: Set the event mask bit for touchpad gestures (950 bytes, patch)
2015-08-14 12:22 UTC, Carlos Garnacho
none Details | Review

Description Carlos Garnacho 2015-08-14 12:21:35 UTC
GTK+ master (soon 3.17.90) implements touchpad gestures on wayland, and provides the GDK_TOUCHPAD_GESTURE_MASK event mask bit for widgets/windows to opt these in.

Just setting this bit in EogScrolledWindow will be enough for GtkGesture to pick these events and do the right thing, attaching a patch for this.

NB: the GTK_CHECK_VERSION is for the current version in gtk+ master, feel free to wait for a gtk+ release and change the check to .90.
Comment 1 Carlos Garnacho 2015-08-14 12:22:16 UTC
Created attachment 309270 [details] [review]
EogScrollView: Set the event mask bit for touchpad gestures

This will be enough for the GtkGestureZoom/Rotate gestures to pick
these events and emit the right signals.
Comment 2 Felix Riemann 2015-08-16 17:01:55 UTC
Is this working on Wayland only?
On my laptop it seems to get confused with two-finger scrolling when I try a zoom gesture.
Comment 3 Carlos Garnacho 2015-08-16 18:16:30 UTC
Yes, this is wayland only atm. You need mutter and gtk+ master (both should get a .90 release this week). If compositor/toolkit agree on touchpad gestures, you should see spew from wl_pointer_gesture* when running eog with WAYLAND_DEBUG=1. Recent libinput/clutter might also be needed, there's been releases for these already though.

It might also be the case that libinput doesn't work properly for your touchpad, libinput/tools/event-debug might help figure out.
Comment 4 Carlos Garnacho 2015-08-16 21:06:36 UTC
Oh forgot to mention, this doesn't work on nested wayland, you need to run the wayland session from gdm or running gnome-shell --wayland --display-server on a tty
Comment 5 Felix Riemann 2015-08-17 20:24:22 UTC
Okay, guess I'll have to wait a bit until I can try it as my laptop doesn't like replacing a running Wayland instance. However, this looks pretty safe, so I'll include it anyway. I'll raise the version check to 3.17.7 as that will match the next GTK release no matter whether it's going to be .7 or .90.
Comment 6 Felix Riemann 2015-08-17 20:39:52 UTC
And in. Thanks! :)

commit 456b3664738dac11898e0ee0dea41f4994da1065
Author: Carlos Garnacho <>
Date:   Fri Aug 14 13:56:00 2015 +0200

    EogScrollView: Set the event mask bit for touchpad gestures
    
    This will be enough for the GtkGestureZoom/Rotate gestures to pick
    these events and emit the right signals.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=753627

---
This problem has been fixed in the unstable development version. The fix will be available in the next major software release. You may need to upgrade your Linux distribution to obtain that newer version.