GNOME Bugzilla – Bug 753616
rtspconnection: criticals when two clients use same x-sessioncookie
Last modified: 2018-03-21 21:40:21 UTC
We have a software that starting several clients but have bad random generation so sometimes there are the same x-sessioncookie in two GET requests this causes a CRITICAL. CRITICAL **: gst_rtsp_connection_do_tunnel: assertion ‘(ts1 == TUNNEL_STATE_GET && ts2 == TUNNEL_STATE_POST) || (ts1 == TUNNEL_STATE_POST && ts2 == TUNNEL_STATE_GET)’ failed As I understands it CRITICALS are for programming errors only, not for handling bad behavior from client.
Since you know what causes it, could you make a small unit test that demonstrates the issue?
Do you plan on working on this an making a patch and/or unit test?
This is far down in our priority list so in practice we can say that we don't plan to do this. If you want to close it please do that. We can create a new ticket if we actually come so far down in the list. The background for this ticket was that I was recommended to add a ticket on this when I discussed the issue on #gstreamer chat.
Created attachment 368543 [details] [review] gst-rtsp-server patch
Any news about this one.
Comment on attachment 368543 [details] [review] gst-rtsp-server patch Looks good to me in principle, but maybe the lock should be taken all around handle_tunnel() instead of unlocking before handle_tunnel() and locking again inside again?
Please elaborate. I do not understand. As I see it handle_tunnel is not locking clients priv->lock . It locks tunnels_lock and clients priv->watch_lock
Any news about this one ?
Comment on attachment 368543 [details] [review] gst-rtsp-server patch Should be good to go after 1.14
commit 3a129300f0e6e7d0336c2d2c315a2b36e052eaf1 (HEAD -> master) Author: Göran Jönsson <goranjn@axis.com> Date: Thu Feb 15 13:26:16 2018 +0100 rtsp-client:Error handling when equal http session cookie There are some clients that are sending same session cookie on random basis. https://bugzilla.gnome.org/show_bug.cgi?id=753616
Candiate for 1.14 ?