After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 753606 - Non-void function should return a value
Non-void function should return a value
Status: RESOLVED FIXED
Product: libgit2-glib
Classification: Core
Component: General
git master
Other FreeBSD
: Normal normal
: ---
Assigned To: gitg-maint
gitg-maint
Depends on:
Blocks:
 
 
Reported: 2015-08-14 07:03 UTC by Ting-Wei Lan
Modified: 2019-02-22 03:51 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Fix return value for ggit_index_entry_is_conflict (837 bytes, patch)
2015-08-14 07:07 UTC, Ting-Wei Lan 		committed Details | Review

Description Ting-Wei Lan 2015-08-14 07:03:56 UTC 
ggit_index_entry_is_conflict() returns gboolean, so it cannot use g_return_if_fail.
Comment 1 Ting-Wei Lan 2015-08-14 07:07:05 UTC 
Created attachment 309241 [details] [review]
Fix return value for ggit_index_entry_is_conflict
Comment 2 Ignacio Casal Quinteiro (nacho) 2015-08-14 07:09:42 UTC 
Review of attachment 309241 [details] [review]:

Looks good. Thanks.
Comment 3 Ting-Wei Lan 2015-08-14 07:13:40 UTC 
Attachment 309241 [details] pushed as 638d16c - Fix return value for ggit_index_entry_is_conflict