GNOME Bugzilla – Bug 753576
Revert commit 'gnome-suites-core-deps-3.18: clutter requires libinput and libxkbcommon'
Last modified: 2015-12-15 16:54:00 UTC
The commit message says: They are required for evdev input, regardless of wayland. --enable-evdev-input is added only when wayland condition is set, so libinput and libxkbcommon should be kept in wayland condition. Do we need to add evdev condition to make --enable-evdev-input handled separately?
Created attachment 309192 [details] [review] Revert "gnome-suites-core-deps-3.18: clutter requires libinput and libxkbcommon" This reverts commit 760b72af16d24a503ee608d40203f395d9f3d1a7. evdev is only enabled when wayland condition is set, so libinput and libxkbcommon dependencies should stay in wayland condition.
I see that evdev can be set independently from wayland. And it's the case for my setup. I don't see anywhere in the clutter configure.ac that evdev is only enabled with wayland, am I wrong? Or perhaps I have a weird jhbuild setup with obsolete flags, and evdev shouldn't be enabled without wayland?
(In reply to Luca Bruno from comment #2) > I see that evdev can be set independently from wayland. And it's the case > for my setup. So we can add a new condition flag for it. > > I don't see anywhere in the clutter configure.ac that evdev is only enabled > with wayland, am I wrong? > > Or perhaps I have a weird jhbuild setup with obsolete flags, and evdev > shouldn't be enabled without wayland? This is in jhbuild moduleset: <if condition-set="wayland"> <autogenargs value="--enable-wayland-backend --enable-wayland-compositor --enable-evdev-input"/> </if>
I see. Perhaps my setup is very old and I'm disabling wayland support with configure flags. Hence evdev is enabled by default. So why should evdev only be enabled with wayland?
It was done in commit a287b83 for GNOME 3.12 to make jhbuild work on FreeBSD. FreeBSD currently doesn't support wayland, evdev, libinput.
Created attachment 309193 [details] [review] core-deps-3.18: Move --enable-evdev-input to a separate condition for clutter
Do you accept the patch? We have to use 'jhbuild build --skip=libinput' on FreeBSD now because libinput and evdev are not ported to FreeBSD.
I've reverted in 42cc9e1aa7032b18d510dca2a479b886c49b340f , I don't feel like adding a new condition without jhbuild developers agreement.
Created attachment 309930 [details] [review] core-deps-3.18: Move --enable-evdev-input to a separate condition for clutter
Created attachment 314417 [details] [review] core-deps-3.18/3.20: Move --enable-evdev-input to a separate condition for clutter
Fine by me.
Attachment 314417 [details] pushed as 533539b - core-deps-3.18/3.20: Move --enable-evdev-input to a separate condition for clutter